Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sapling should interop with Jest --watch mode #555

Closed
steveluscher opened this issue Mar 9, 2023 · 5 comments
Closed

Sapling should interop with Jest --watch mode #555

steveluscher opened this issue Mar 9, 2023 · 5 comments

Comments

@steveluscher
Copy link
Contributor

steveluscher commented Mar 9, 2023

The testing library Jest has a mode where it can run tests related to changed files, according to the SCM.

I wonder if Sapling could provide some sort of reasonable ‘API compatibility’ with git by synthesizing just enough of the .git folder to be useful. That way tools that look for a .git folder would Just Work™ (see also #556).

Problem

jest --watch

…yields the following error:

Determining test suites to run...
--watch is not supported without git/hg, please use --watchAll
@fanzeyi
Copy link
Member

fanzeyi commented Mar 10, 2023

Do you want to open an issue in jest repo? They probably just need to recognize Sapling and they probably have Watchman support already.

@fanzeyi
Copy link
Member

fanzeyi commented Mar 10, 2023

Looks like there is some basic support in Jest already: jestjs/jest#13674

@fanzeyi
Copy link
Member

fanzeyi commented Mar 10, 2023

aaaaaaand I found jestjs/jest#13941

You should try updating Jest to 29.5.0.

@muirdm
Copy link
Contributor

muirdm commented Mar 10, 2023

Closing assuming the above mentioned support in jest is sufficient.

@muirdm muirdm closed this as completed Mar 10, 2023
@steveluscher
Copy link
Contributor Author

And me, here, on the ancient 29.4.2. 😂

Thanks for doing my Googling for me; sorry to waste your time! :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants