Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates invalid zip file #83

Closed
johnflux opened this issue Jun 10, 2021 · 1 comment
Closed

Creates invalid zip file #83

johnflux opened this issue Jun 10, 2021 · 1 comment

Comments

@johnflux
Copy link

https://github.com/facebookexperimental/eden/blob/694ffecfc950c381522442f20642a38666229271/eden/scm/edenscm/mercurial/archival.py#L256

This should be a 0, not a 1. This is refering to the local-header extra fields, not the central directory

@yancouto
Copy link
Contributor

I'm closing this since it's out of date. A lot has changed with the latest Sapling release, in which we now support the client on Git repos. Please reopen if you're still having issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants