Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure: 'apache::thrift::HandlerCallbackPtr' has not been declared #1212

Open
SEIAROTg opened this issue Apr 13, 2024 · 0 comments
Open

Build failure: 'apache::thrift::HandlerCallbackPtr' has not been declared #1212

SEIAROTg opened this issue Apr 13, 2024 · 0 comments

Comments

@SEIAROTg
Copy link

I was trying to build watchman from v2024.04.08 release 1 and got this same failure in many different environments (including using Dockerfiles 2):

FAILED: CMakeFiles/fb303.dir/fb303/TFunctionStatHandler.cpp.o 
/usr/bin/c++ -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_NO_LIB -DGFLAGS_IS_A_DLL=0 -I/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git -I. -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/gflags-2qY5_V0SK27SAFBG1hAFp9hmBNNFh2vWOe9AzrEr4y8/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/glog-WPvfZBnUlKQvwFWGGNjnZxQgaViRC25iBuzp16k9drg/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/boost-3kB5dHICPhyGAlFMZp7aowyLgIEb8T_MTjpsGcFp1cc/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/double-conversion-YyYprTTS5M7GCR5C_5eeHZSfpB3PcPtMLZZtBnUl700/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/libevent-_OpxS6wJ-JJ9-t0CMB6G61saYmxsfLPnJTBNGCHVyXg/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/zlib-cEUU7oQ3SWTCdGMNXmhPWUuQK59X9ZA2JMirRdTSXWg/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/bz2-lX_RTgtLM8fwSHRCQlN42J3xdTtqcpgU2vJN0Zj9ze4/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/xz-yVE1QHzTYjAlrqShyr75CvrXk5vEGOZ8fEHAxi7BopM/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/lz4-SEa0im2AFa7ILg6xHIb3GRo7nDBpgA6-_m5XIO0vPCk/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/zstd-E-OglGYB6g1xRcEl92H4ASwdMwUDeHe6-AiTRYF5Rpg/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/snappy-WnLj2pTLLd8wyOlfm3vi8MGt1Huw0MZ3y-dhmdrFI7I/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/libsodium-ejYqgMjMcbWabR9_J9BxXVxVlyPJxZYLdHYiFgJxlkc/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/folly/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/fmt-mU75dkBvy5NSlR2gZihcj0gH_V_rX6WpjA_oIx2O_oo/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/fbthrift/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/wangle/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/fizz/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/mvfst/include -O2 -g -DNDEBUG -fsized-deallocation -std=c++17 -MD -MT CMakeFiles/fb303.dir/fb303/TFunctionStatHandler.cpp.o -MF CMakeFiles/fb303.dir/fb303/TFunctionStatHandler.cpp.o.d -o CMakeFiles/fb303.dir/fb303/TFunctionStatHandler.cpp.o -c /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/TFunctionStatHandler.cpp
In file included from /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/TFunctionStatHandler.h:19,
                 from /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/TFunctionStatHandler.cpp:17:
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:217:7: error: ‘apache::thrift::HandlerCallbackPtr’ has not been declared
       apache::thrift::HandlerCallbackPtr<
       ^~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:217:41: error: expected ‘,’ or ‘...’ before ‘<’ token
       apache::thrift::HandlerCallbackPtr<
                                         ^
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:254:7: error: ‘apache::thrift::HandlerCallbackPtr’ has not been declared
       apache::thrift::HandlerCallbackPtr<
       ^~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:254:41: error: expected ‘,’ or ‘...’ before ‘<’ token
       apache::thrift::HandlerCallbackPtr<
                                         ^
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:300:7: error: ‘apache::thrift::HandlerCallbackPtr’ has not been declared
       apache::thrift::HandlerCallbackPtr<
       ^~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:300:41: error: expected ‘,’ or ‘...’ before ‘<’ token
       apache::thrift::HandlerCallbackPtr<
                                         ^
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:216:8: error: ‘void facebook::fb303::BaseService::async_eb_getCounters(int)’ marked ‘override’, but does not override
   void async_eb_getCounters(
        ^~~~~~~~~~~~~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:253:8: error: ‘void facebook::fb303::BaseService::async_eb_getRegexCounters(int)’ marked ‘override’, but does not override
   void async_eb_getRegexCounters(
        ^~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:299:8: error: ‘void facebook::fb303::BaseService::async_eb_getSelectedCounters(int)’ marked ‘override’, but does not override
   void async_eb_getSelectedCounters(
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h: In member function ‘void facebook::fb303::BaseService::async_eb_getCounters(int)’:
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:221:53: error: ‘callback’ was not declared in this scope
                               callback_ = std::move(callback),
                                                     ^~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:221:53: note: suggested alternative: ‘calloc’
                               callback_ = std::move(callback),
                                                     ^~~~~~~~
                                                     calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h: In lambda function:
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:228:9: error: ‘callback_’ was not declared in this scope
         callback_->exception(folly::make_exception_wrapper<Exn>(
         ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:228:9: note: suggested alternative: ‘calloc’
         callback_->exception(folly::make_exception_wrapper<Exn>(
         ^~~~~~~~~
         calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:233:24: error: ‘callback_’ was not declared in this scope
         auto* reqCtx = callback_->getRequestContext();
                        ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:233:24: note: suggested alternative: ‘calloc’
         auto* reqCtx = callback_->getRequestContext();
                        ^~~~~~~~~
                        calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:248:9: error: ‘callback_’ was not declared in this scope
         callback_->exception(std::current_exception());
         ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:248:9: note: suggested alternative: ‘calloc’
         callback_->exception(std::current_exception());
         ^~~~~~~~~
         calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h: In member function ‘void facebook::fb303::BaseService::async_eb_getRegexCounters(int)’:
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:259:53: error: ‘callback’ was not declared in this scope
                               callback_ = std::move(callback),
                                                     ^~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:259:53: note: suggested alternative: ‘calloc’
                               callback_ = std::move(callback),
                                                     ^~~~~~~~
                                                     calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:260:50: error: ‘regex’ was not declared in this scope
                               regex_ = std::move(regex),
                                                  ^~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:260:50: note: suggested alternative: ‘rexec’
                               regex_ = std::move(regex),
                                                  ^~~~~
                                                  rexec
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h: In lambda function:
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:267:9: error: ‘callback_’ was not declared in this scope
         callback_->exception(folly::make_exception_wrapper<Exn>(
         ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:267:9: note: suggested alternative: ‘calloc’
         callback_->exception(folly::make_exception_wrapper<Exn>(
         ^~~~~~~~~
         calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:273:24: error: ‘callback_’ was not declared in this scope
         auto* reqCtx = callback_->getRequestContext();
                        ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:273:24: note: suggested alternative: ‘calloc’
         auto* reqCtx = callback_->getRequestContext();
                        ^~~~~~~~~
                        calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:282:41: error: ‘regex_’ was not declared in this scope
         getRegexCounters(res, std::move(regex_));
                                         ^~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:282:41: note: suggested alternative: ‘rexec’
         getRegexCounters(res, std::move(regex_));
                                         ^~~~~~
                                         rexec
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:294:9: error: ‘callback_’ was not declared in this scope
         callback_->exception(std::current_exception());
         ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:294:9: note: suggested alternative: ‘calloc’
         callback_->exception(std::current_exception());
         ^~~~~~~~~
         calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h: In member function ‘void facebook::fb303::BaseService::async_eb_getSelectedCounters(int)’:
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:305:53: error: ‘callback’ was not declared in this scope
                               callback_ = std::move(callback),
                                                     ^~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:305:53: note: suggested alternative: ‘calloc’
                               callback_ = std::move(callback),
                                                     ^~~~~~~~
                                                     calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:306:49: error: ‘keys’ was not declared in this scope
                               keys_ = std::move(keys),
                                                 ^~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:306:49: note: suggested alternative: ‘key_t’
                               keys_ = std::move(keys),
                                                 ^~~~
                                                 key_t
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h: In lambda function:
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:313:9: error: ‘callback_’ was not declared in this scope
         callback_->exception(folly::make_exception_wrapper<Exn>(
         ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:313:9: note: suggested alternative: ‘calloc’
         callback_->exception(folly::make_exception_wrapper<Exn>(
         ^~~~~~~~~
         calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:319:24: error: ‘callback_’ was not declared in this scope
         auto* reqCtx = callback_->getRequestContext();
                        ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:319:24: note: suggested alternative: ‘calloc’
         auto* reqCtx = callback_->getRequestContext();
                        ^~~~~~~~~
                        calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:323:44: error: ‘keys_’ was not declared in this scope
         getSelectedCounters(res, std::move(keys_));
                                            ^~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:323:44: note: suggested alternative: ‘key_t’
         getSelectedCounters(res, std::move(keys_));
                                            ^~~~~
                                            key_t
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:334:9: error: ‘callback_’ was not declared in this scope
         callback_->exception(std::current_exception());
         ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:334:9: note: suggested alternative: ‘calloc’
         callback_->exception(std::current_exception());
         ^~~~~~~~~
         calloc
[2/4] Building CXX object CMakeFiles/fb303.dir/fb303/BaseService.cpp.o
FAILED: CMakeFiles/fb303.dir/fb303/BaseService.cpp.o 
/usr/bin/c++ -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_NO_LIB -DGFLAGS_IS_A_DLL=0 -I/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git -I. -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/gflags-2qY5_V0SK27SAFBG1hAFp9hmBNNFh2vWOe9AzrEr4y8/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/glog-WPvfZBnUlKQvwFWGGNjnZxQgaViRC25iBuzp16k9drg/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/boost-3kB5dHICPhyGAlFMZp7aowyLgIEb8T_MTjpsGcFp1cc/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/double-conversion-YyYprTTS5M7GCR5C_5eeHZSfpB3PcPtMLZZtBnUl700/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/libevent-_OpxS6wJ-JJ9-t0CMB6G61saYmxsfLPnJTBNGCHVyXg/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/zlib-cEUU7oQ3SWTCdGMNXmhPWUuQK59X9ZA2JMirRdTSXWg/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/bz2-lX_RTgtLM8fwSHRCQlN42J3xdTtqcpgU2vJN0Zj9ze4/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/xz-yVE1QHzTYjAlrqShyr75CvrXk5vEGOZ8fEHAxi7BopM/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/lz4-SEa0im2AFa7ILg6xHIb3GRo7nDBpgA6-_m5XIO0vPCk/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/zstd-E-OglGYB6g1xRcEl92H4ASwdMwUDeHe6-AiTRYF5Rpg/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/snappy-WnLj2pTLLd8wyOlfm3vi8MGt1Huw0MZ3y-dhmdrFI7I/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/libsodium-ejYqgMjMcbWabR9_J9BxXVxVlyPJxZYLdHYiFgJxlkc/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/folly/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/fmt-mU75dkBvy5NSlR2gZihcj0gH_V_rX6WpjA_oIx2O_oo/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/fbthrift/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/wangle/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/fizz/include -isystem /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/mvfst/include -O2 -g -DNDEBUG -fsized-deallocation -std=c++17 -MD -MT CMakeFiles/fb303.dir/fb303/BaseService.cpp.o -MF CMakeFiles/fb303.dir/fb303/BaseService.cpp.o.d -o CMakeFiles/fb303.dir/fb303/BaseService.cpp.o -c /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.cpp
In file included from /tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.cpp:17:
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:217:7: error: ‘apache::thrift::HandlerCallbackPtr’ has not been declared
       apache::thrift::HandlerCallbackPtr<
       ^~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:217:41: error: expected ‘,’ or ‘...’ before ‘<’ token
       apache::thrift::HandlerCallbackPtr<
                                         ^
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:254:7: error: ‘apache::thrift::HandlerCallbackPtr’ has not been declared
       apache::thrift::HandlerCallbackPtr<
       ^~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:254:41: error: expected ‘,’ or ‘...’ before ‘<’ token
       apache::thrift::HandlerCallbackPtr<
                                         ^
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:300:7: error: ‘apache::thrift::HandlerCallbackPtr’ has not been declared
       apache::thrift::HandlerCallbackPtr<
       ^~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:300:41: error: expected ‘,’ or ‘...’ before ‘<’ token
       apache::thrift::HandlerCallbackPtr<
                                         ^
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:216:8: error: ‘void facebook::fb303::BaseService::async_eb_getCounters(int)’ marked ‘override’, but does not override
   void async_eb_getCounters(
        ^~~~~~~~~~~~~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:253:8: error: ‘void facebook::fb303::BaseService::async_eb_getRegexCounters(int)’ marked ‘override’, but does not override
   void async_eb_getRegexCounters(
        ^~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:299:8: error: ‘void facebook::fb303::BaseService::async_eb_getSelectedCounters(int)’ marked ‘override’, but does not override
   void async_eb_getSelectedCounters(
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h: In member function ‘void facebook::fb303::BaseService::async_eb_getCounters(int)’:
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:221:53: error: ‘callback’ was not declared in this scope
                               callback_ = std::move(callback),
                                                     ^~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:221:53: note: suggested alternative: ‘calloc’
                               callback_ = std::move(callback),
                                                     ^~~~~~~~
                                                     calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h: In lambda function:
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:228:9: error: ‘callback_’ was not declared in this scope
         callback_->exception(folly::make_exception_wrapper<Exn>(
         ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:228:9: note: suggested alternative: ‘calloc’
         callback_->exception(folly::make_exception_wrapper<Exn>(
         ^~~~~~~~~
         calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:233:24: error: ‘callback_’ was not declared in this scope
         auto* reqCtx = callback_->getRequestContext();
                        ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:233:24: note: suggested alternative: ‘calloc’
         auto* reqCtx = callback_->getRequestContext();
                        ^~~~~~~~~
                        calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:248:9: error: ‘callback_’ was not declared in this scope
         callback_->exception(std::current_exception());
         ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:248:9: note: suggested alternative: ‘calloc’
         callback_->exception(std::current_exception());
         ^~~~~~~~~
         calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h: In member function ‘void facebook::fb303::BaseService::async_eb_getRegexCounters(int)’:
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:259:53: error: ‘callback’ was not declared in this scope
                               callback_ = std::move(callback),
                                                     ^~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:259:53: note: suggested alternative: ‘calloc’
                               callback_ = std::move(callback),
                                                     ^~~~~~~~
                                                     calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:260:50: error: ‘regex’ was not declared in this scope
                               regex_ = std::move(regex),
                                                  ^~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:260:50: note: suggested alternative: ‘rexec’
                               regex_ = std::move(regex),
                                                  ^~~~~
                                                  rexec
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h: In lambda function:
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:267:9: error: ‘callback_’ was not declared in this scope
         callback_->exception(folly::make_exception_wrapper<Exn>(
         ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:267:9: note: suggested alternative: ‘calloc’
         callback_->exception(folly::make_exception_wrapper<Exn>(
         ^~~~~~~~~
         calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:273:24: error: ‘callback_’ was not declared in this scope
         auto* reqCtx = callback_->getRequestContext();
                        ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:273:24: note: suggested alternative: ‘calloc’
         auto* reqCtx = callback_->getRequestContext();
                        ^~~~~~~~~
                        calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:282:41: error: ‘regex_’ was not declared in this scope
         getRegexCounters(res, std::move(regex_));
                                         ^~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:282:41: note: suggested alternative: ‘rexec’
         getRegexCounters(res, std::move(regex_));
                                         ^~~~~~
                                         rexec
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:294:9: error: ‘callback_’ was not declared in this scope
         callback_->exception(std::current_exception());
         ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:294:9: note: suggested alternative: ‘calloc’
         callback_->exception(std::current_exception());
         ^~~~~~~~~
         calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h: In member function ‘void facebook::fb303::BaseService::async_eb_getSelectedCounters(int)’:
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:305:53: error: ‘callback’ was not declared in this scope
                               callback_ = std::move(callback),
                                                     ^~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:305:53: note: suggested alternative: ‘calloc’
                               callback_ = std::move(callback),
                                                     ^~~~~~~~
                                                     calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:306:49: error: ‘keys’ was not declared in this scope
                               keys_ = std::move(keys),
                                                 ^~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:306:49: note: suggested alternative: ‘key_t’
                               keys_ = std::move(keys),
                                                 ^~~~
                                                 key_t
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h: In lambda function:
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:313:9: error: ‘callback_’ was not declared in this scope
         callback_->exception(folly::make_exception_wrapper<Exn>(
         ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:313:9: note: suggested alternative: ‘calloc’
         callback_->exception(folly::make_exception_wrapper<Exn>(
         ^~~~~~~~~
         calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:319:24: error: ‘callback_’ was not declared in this scope
         auto* reqCtx = callback_->getRequestContext();
                        ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:319:24: note: suggested alternative: ‘calloc’
         auto* reqCtx = callback_->getRequestContext();
                        ^~~~~~~~~
                        calloc
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:323:44: error: ‘keys_’ was not declared in this scope
         getSelectedCounters(res, std::move(keys_));
                                            ^~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:323:44: note: suggested alternative: ‘key_t’
         getSelectedCounters(res, std::move(keys_));
                                            ^~~~~
                                            key_t
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:334:9: error: ‘callback_’ was not declared in this scope
         callback_->exception(std::current_exception());
         ^~~~~~~~~
/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/repos/git.luolix.top-facebook-fb303.git/fb303/BaseService.h:334:9: note: suggested alternative: ‘calloc’
         callback_->exception(std::current_exception());
         ^~~~~~~~~
         calloc
ninja: build stopped: subcommand failed.
Command '['/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/installed/cmake-SrzGE-Vba6-olpU8T8OUrNG36QRk7E5lyXP-5dBmFoI/bin/cmake', '--build', '/tmp/fbcode_builder_getdeps-ZtmpZwatchman-2024.04.08.00ZbuildZfbcode_builder-root/build/fb303', '--target', 'install', '--config', 'RelWithDebInfo', '-j', '80']' returned non-zero exit status 1.
!! Failed

Looks like HandlerCallbackPtr was recently added to fbthrift in 3, and fb303 started to reference it shortly afterwards it in 4. watchman pins the version of fbthrift but not fb303 5, effectively uses fb303 from HEAD, which is incompatible with the pinned fbthrift.

I edited watchman/blob/main/build/fbcode_builder/manifests/fb303 locally to pin the fb303 version to before the change and the build succeeded:

[git]
repo_url = https://github.com/facebook/fb303.git
rev = edf859375064720f5a79225ec73ad1a4ec3e07cc

Can we pin the version of fb303 and other relevant dependencies?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SEIAROTg