Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark v1.5.x deprecated functions as deprecated #3405

Closed
embg opened this issue Dec 28, 2022 · 1 comment · Fixed by #3408
Closed

Mark v1.5.x deprecated functions as deprecated #3405

embg opened this issue Dec 28, 2022 · 1 comment · Fixed by #3408
Assignees
Labels
release-blocking Must be done by the release

Comments

@embg
Copy link
Contributor

embg commented Dec 28, 2022

We have a number of comments like

Note : this prototype will be marked as deprecated and generate compilation warnings on reaching v1.5.x

where the prototypes aren't actually marked as deprecated. For example:

zstd/lib/zstd.h

Lines 2445 to 2447 in 90597d7

* Note : this prototype will be marked as deprecated and generate compilation warnings on reaching v1.5.x
*/
ZSTDLIB_STATIC_API size_t ZSTD_initDStream_usingDict(ZSTD_DStream* zds, const void* dict, size_t dictSize);

Filing an issue to remind myself to fix this.

@embg embg self-assigned this Dec 28, 2022
@embg embg added the release-blocking Must be done by the release label Dec 28, 2022
@Cyan4973
Copy link
Contributor

Yes, this is a good point @embg .
These symbols should probably be marked as deprecated now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocking Must be done by the release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants