Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Outline View: <li> indentation is larger than expected when having no children #230

Closed
liuderchi opened this issue Apr 26, 2018 · 2 comments
Closed

Outline View: <li> indentation is larger than expected when having no children #230

liuderchi opened this issue Apr 26, 2018 · 2 comments

Comments

@liuderchi
Copy link

Description

Given 2 list items at same level (having same parent node) A and B with

  • <li> A having no children
  • <li> B having some children

found that their indentation (or padding-left) are not equal.

Expected Behavior

<li> A has same indentation as <li> B

Actual Behavior

padding-left of <li> A is larger than <li> B

In this example where <li> A is <head>, <li> B is <body>

expected

Additional Details

  • it's found at package ide-html with this snippet
<!DOCTYPE html>
<html lang="en" dir="ltr">
    <head>
        <title>Home</title>
    </head>
    <body>
      <div class=""></div>
    </body>
</html>
  • Confirmed that HTML Language server parse the HTML correctly after checking debug message from Language server
  • When <head> having some children, it's applied with style from atom core (padding-left: 28px;)

screen shot 2018-04-26 at 11 17 52 pm

screen shot 2018-04-26 at 11 18 15 pm

Versions

  • Atom: 1.26.0
  • Client OS: macOS 10.13.4
  • atom-ide-ui: 0.11.1
@liuderchi liuderchi mentioned this issue Apr 26, 2018
Open
@liuderchi liuderchi changed the title Outline view: <li> indentation is larger than expected when having no children Outline View: <li> indentation is larger than expected when having no children Apr 26, 2018
@laughedelic
Copy link

There is already an open issue for this: #176. Probably you know how to fix it?

@matthewwithanm
Copy link
Contributor

thanks for the report @liuderchi! like @laughedelic mentioned, this is a duplicate of #176 so i'm going to close. this is on @wbinnssmith's radar but he's currently out. i'm sure he would love to come back to a PR though (:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthewwithanm @laughedelic @liuderchi