Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Tracking small behavior change in upcoming cargo-hakari (0.9.12) #586

Closed
sunshowers opened this issue Feb 3, 2022 · 3 comments
Closed

Comments

@sunshowers
Copy link
Contributor

sunshowers commented Feb 3, 2022

There's a small behavior change in the next version of cargo-hakari due to a bugfix (e03f119).

For influxdb_iox the new version results in a small change: https://gist.github.com/sunshowers/d231b22187f5ff9bbae67cdb07190c14 (cc @carols10cents)

This is technically not a breaking change to the format per the stability policy because it is a bugfix, but it looks like it does cause changes to existing hakari files in the wild. While I could put in the effort to gate this change behind a config option, it'll be a bunch of extra documentation and maintenance effort so I wanted to see if folks were OK with this change potentially breaking CI very briefly while y'all update to the new version.

I'll probably release the new version within 2 weeks or so.

@carols10cents
Copy link

carols10cents commented Feb 7, 2022

I love bugfixes and I'm happy to make a fix when updating :)

@sunshowers
Copy link
Contributor Author

Thank you!

@sunshowers
Copy link
Contributor Author

This was landed in guppy 0.9.12.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants