Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

[feature request] Upon exiting, print out a list of modified and non-modified files #87

Open
rattrayalex-stripe opened this issue Jul 21, 2017 · 4 comments

Comments

@rattrayalex-stripe
Copy link

It would be helpful to be able to quickly review the paths of the files which had changed and which had been ignored.

@modocache
Copy link
Contributor

I agree! I wonder whether this might be difficult with many thousands of modified files, though.

@rattrayalex-stripe
Copy link
Author

rattrayalex-stripe commented Jul 21, 2017

Difficult or annoying? 😉

Perhaps display "... and 1337 others" when n > 100 ?

Though if you're using codemod to go line-by-line through thousands of files... you might appreciate this even more / it's a small price to pay?

@keyan
Copy link
Contributor

keyan commented Aug 18, 2017

This seems helpful. I have a pretty clear idea of how to handle this cleanly. I'll open my PR once #90 is merged.

I am imagining:

<run codemod>
"Would you like to see a list of modified (and ignored files)?"
"y = yes, n = no, m = modified only"
<newline separated list, uses the `n > 100` rule Alex mentioned>

@rattrayalex-stripe
Copy link
Author

"y = yes, n = no, m = modified only"
maybe could be
"y = yes, n = no, m = modified only, c = clipboard"
where clipboard copies the entire (including n > 100) to the clipboard. I'd rather put it into a file but can't think of a good way for this to happen easily.

I am imagining the list will sometimes go into a changelog file, github comment, slack channel message, or similar.

It could also be good to instead have
"y = yes, n = no, m = modified only", i = ignored only
since it is easy to infer the modified files from the commit, but it is not possible to infer the ignored files. They are likely to be a smaller list, and may be valuable to include in a commit message or similar.

Just 2c, take with a grain of salt – I haven't actually used codemod much myself 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants