This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Handling Enter and Backspace for empty list blocks closer to text processors behaviour #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rst list item block - remove it and replace to soft newline at preceding list item block.
…(this will end list).
…ck above (common behaviour of text processors).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handling Backspace when cursor is on empty non-first list item block.
Current behaviour - unstyle current block, that will split a list of current list item is not last.
Proposed behaviour - remove current block and replace it with soft newline at preceding list item block.
This behaviour is common to text processors. It will be possible to use multiline text at list item.
Handling Enter when cursor is on last empty list item.
Current behaviour - create new list item.
Proposed behaviour - unstyle the block, this will end a list.
If use this behaviour for every list item, not only last, this will split list. Which is not common for text processors. (Text processors can unstyle block and preserve it in list, but it's not possible in Draft.js for now)
Removed restriction on indenting beyond one level deeper than the block above (common behaviour of text processors).
Fixes issue List item nesting not preserved on dedent #270.
Test Plan
No tests yet.