Configurable symbolic link following. #19
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
This is a large api change unfortunately. Adding another parameter to find and findNative would require |
| this.extensions = options && options.extensions || ['.js']; | ||
| this.ignore = options && options.ignore || null; | ||
| this.useNative = options && options.useNative || false; | ||
| this.followSymlinks = options && options.followSymlinks || true; |
There was a problem hiding this comment.
This should default to false for backwards compatibility. Was testing this alongside jest.
|
Related: jestjs/jest#219 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
jacobstr
force-pushed
the
master
branch
2 times, most recently
from
354c08d
to
05c7628
Compare
Adds a followSymlink option to the FileFinder. Potentially useful when traversing node_module folders that contain symbolic links - e.g. due to `npm link`.
|
Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed. |
|
We rewrote node-haste with a new implementation. Please feel free to reopen this pull request with a version against the new node-haste if you believe this issue still persists. jest 0.8.0 will be launched with the new implementation of node-haste towards the end of the year. The integration work can be tracked in jestjs/jest#599 |
Adds a followSymlink option to the FileFinder. Potentially useful when traversing
node_modules folders contain symbolic links - e.g. due to
npm link.My personal use case is a bit messy to explain, see:
https://github.com/mover-io/jestsymlink
This might not be the best way to address the issue. It allows jest to traverse inside of a node_modules/symlinked_folder to populate the ResourceMap it while generating it's normalized id's.