Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very large and always positive residuals #462

Closed
DzimitryM opened this issue Aug 10, 2022 · 2 comments
Closed

Very large and always positive residuals #462

DzimitryM opened this issue Aug 10, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@DzimitryM
Copy link

DzimitryM commented Aug 10, 2022

Project Robyn

Describe issue

In some of the output solutions the difference between actual and predicted response is large and always positive.
This issue takes place after upgrading Robyn from v3.6.3 to v3.7.0 / v.3.7.1.
An example of a strange output, it was chosen by the internal clustering algorithm as one of the best.
1_149_6

Provide dummy data & model configuration

Running the original demo.R without modifications gives such kind of outputs.
It uses weekly simulated data.

Working with 'the real world' data also provides such biased predictions even more often.

Environment & Robyn version

R version 4.2.1
Robyn version: 3.7.0, 3.7.1

@laresbernardo laresbernardo self-assigned this Aug 10, 2022
@laresbernardo laresbernardo added the bug Something isn't working label Aug 10, 2022
@laresbernardo
Copy link
Collaborator

Yes! Good catch @DzimitryM
Missed adding the intercept to depVarHat. Already pushed a fix. Please, feel free to update the package and re-try and close if the issue is solved. Thanks for noticing and reporting!

@DzimitryM
Copy link
Author

Thank you @laresbernardo for the prompt fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants