Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkey for 'switch parent way' is not working. #634

Open
Bonkles opened this issue Oct 31, 2022 · 1 comment
Open

Hotkey for 'switch parent way' is not working. #634

Bonkles opened this issue Oct 31, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@Bonkles
Copy link
Contributor

Bonkles commented Oct 31, 2022

Selecting a node should allow us to hit the 'Pause' or '' hotkeys to switch the selection between all the node's parent ways (say, a node at road intersection).

This doesn't appear to be working.

@Bonkles
Copy link
Contributor Author

Bonkles commented Oct 31, 2022

Issue seems to be that we're still using outdated 'surface' code with css selectors to perform this block:

modules/modes/select.js#focusNextParent::447:

            var surface = context.surface();
            surface.selectAll('.related')
                .classed('related', false);

            if (_focusedParentWayId) {
                surface.selectAll(utilEntitySelector([_focusedParentWayId]))
                    .classed('related', true);

@Bonkles Bonkles added this to the v2 General Beta (Extended) milestone Oct 31, 2022
@bhousel bhousel removed this from the v2 General Beta (Extended) milestone Jan 10, 2024
bhousel added a commit that referenced this issue Apr 11, 2024
(re: #1363, re: #1237, re: #634)

This was mostly to fix using the arrow keys to move and rotate the selected
shape, but while in there I fixed a bunch of the other keyboard navigation
shortcuts too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Deferred / Future / Stretch Goals
Development

No branches or pull requests

2 participants