Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Fix for inactive, optional dependencies in guppy 0.13 #596

Closed
sunshowers opened this issue Feb 13, 2022 · 0 comments
Closed

Fix for inactive, optional dependencies in guppy 0.13 #596

sunshowers opened this issue Feb 13, 2022 · 0 comments

Comments

@sunshowers
Copy link
Contributor

This issue tracks the Cargo build simulation fix for inactive, optional dependencies in guppy 0.13 (commit e03f119).

More about this:

[package]
resolver = "2"
name = "main"

[target.'cfg(unix)'.dependencies]
dep = { version = "...", optional = true }

[features]
feat = ["dep/feat"]

Previously, the feature main/feat -> main/dep was activated unconditionally. This did not match Cargo's behavior, which only activated main/feat -> main/dep if dep was already active.

With guppy 0.13, guppy now matches Cargo's behavior.

This also causes a minor behavior change to hakari (#586).

sunshowers referenced this issue Feb 13, 2022
There was a slight issue with the way we were handling inactive,
optional dependencies. This PR should fix that.

Also expand the inside-outside tests to cover both the v1 and v2
resolvers; requires copying the fixture into a temp dir so that the
'resolver = "1"' or "2" can be added to it.

hakari output changes slightly -- this is a bugfix so it's a
non-breaking change.

See the comments in this PR for more.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant