{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":809541830,"defaultBranch":"main","name":"cinderx","ownerLogin":"facebookincubator","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2024-06-03T01:01:22.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/19538647?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1718285873.0","currentOid":""},"activityList":{"items":[{"before":"f8ae647237dce6d480cdd5e5436cc15702b1a92a","after":"c0274d458229b97a1b7b8618820a6ccc10a0a870","ref":"refs/heads/main","pushedAt":"2024-07-09T22:51:40.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unneeded uses of CHANGED_PYCODEOBJECT asserts\n\nSummary:\nThe one in deopt is tied to a CHANGED_PYFRAMEOBJECT assert, and that one seems\nmore relevant given how the code is working with Python frames.\n\nThe one in the runtime helpers seems like it's a nop, the zombie frame doesn't\nexist in 3.12 and either way it was just doing a prefetch.\n\nReviewed By: DinoV\n\nDifferential Revision: D59492956\n\nfbshipit-source-id: 56e0c1182f122d6120ef1680bffb30dc7a5b1c48","shortMessageHtmlLink":"Remove unneeded uses of CHANGED_PYCODEOBJECT asserts"}},{"before":"e5be88aec42b77e8192436411e2cd29129884115","after":"f8ae647237dce6d480cdd5e5436cc15702b1a92a","ref":"refs/heads/main","pushedAt":"2024-07-09T19:16:22.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add inplace long optimization that matches bin op optimization\n\nSummary: While working on D59343577 I ran into D33724533 which made me think that this was the correct approach to handling the inplace op case as well. Turns out we still need to know the types in ssa due to loops, but I coded all of this up before discovering it, so may as well improve the code gen for inplace ops.\n\nReviewed By: alexmalyshev\n\nDifferential Revision: D59477911\n\nfbshipit-source-id: 4c610b5139a478b6d2dfe5b65f321f5aa3f2a705","shortMessageHtmlLink":"Add inplace long optimization that matches bin op optimization"}},{"before":"52181889108d5e04660b9752499e06c0bd5ebbf9","after":"e5be88aec42b77e8192436411e2cd29129884115","ref":"refs/heads/main","pushedAt":"2024-07-09T16:48:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add update_hir_expected script\n\nSummary:\nWe had this helpful script in the old repo but it doesn't seem to have made it over into fbcode. This makes it simple to update the HIR after making a change which might modify it.\n\nThis brings it over and simply updates the `TESTS_DIR` path.\n\nReviewed By: alexmalyshev\n\nDifferential Revision: D59477393\n\nfbshipit-source-id: a22e549eec0e6956f4f9d47fd9473aff45b75d0b","shortMessageHtmlLink":"Add update_hir_expected script"}},{"before":"d29a07268cdfea226f594e6639d5ac75644abd1f","after":"52181889108d5e04660b9752499e06c0bd5ebbf9","ref":"refs/heads/main","pushedAt":"2024-07-09T16:13:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix issue where we crash with multiple primitive arguments\n\nSummary:\nThere's a bug where we're reading the typed argument info totally wrong.  This fixes it so that we aren't double indexing through the offset argument.\n\nThis is a port of D57226161 which never landed in fbcode.\n\nReviewed By: alexmalyshev\n\nDifferential Revision: D59487242\n\nfbshipit-source-id: d06735136bfc4ce39ba847b554550266b046bf04","shortMessageHtmlLink":"Fix issue where we crash with multiple primitive arguments"}},{"before":"c7890ce4af558235dbac4974ceeb3bd70644d42b","after":"d29a07268cdfea226f594e6639d5ac75644abd1f","ref":"refs/heads/main","pushedAt":"2024-07-09T15:42:20.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Assertion: PYLONG_DATA_CHANGED\n\nSummary: This code comes from CPython so we can just use the current version that's in 3.12.\n\nDifferential Revision: D59233258\n\nfbshipit-source-id: cd45d037f23453700eb00d122554e7f580bd0f07","shortMessageHtmlLink":"Assertion: PYLONG_DATA_CHANGED"}},{"before":"ee0a0c84ae673fbd19d24cb814cbc57e30dca3de","after":"c7890ce4af558235dbac4974ceeb3bd70644d42b","ref":"refs/heads/main","pushedAt":"2024-07-08T20:23:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Improve how we fetch bytecode instrs from PyCodeObject\n\nSummary:\nThere's a number of places where we're still indexing into raw byte objects and\nthen casting them to `_Py_CODEUNIT` to read the opcode.  For C code, this diff\nadds two new `codeUnit()` and `countInstrs()` functions that do the necessary\ncasts. For C++ code, we can use `BytecodeInstruction` and `BytecodeInstructionBlock`.\n\nReviewed By: jbower-fb\n\nDifferential Revision: D59467714\n\nfbshipit-source-id: 3d484bc10dbdd4c41a298e300e2f05a618ac06cb","shortMessageHtmlLink":"Improve how we fetch bytecode instrs from PyCodeObject"}},{"before":"dba3bf0b802fb9b72f0ccb8510e5ded7b6e83ba7","after":"ee0a0c84ae673fbd19d24cb814cbc57e30dca3de","ref":"refs/heads/main","pushedAt":"2024-07-08T20:16:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add mixin decorator\n\nSummary: Adds a `mixin` decorator to `__static__` module that allows people to convert a class to dynamic to allow for multiple inheritance from a single static class and any number of dynamic classes.\n\nReviewed By: DinoV\n\nDifferential Revision: D59332309\n\nfbshipit-source-id: 044bd1959ddf50ad22ba75bc53fb8c7763712716","shortMessageHtmlLink":"add mixin decorator"}},{"before":"9a01a1262d3654529c2d714ad290b26816c6f943","after":"dba3bf0b802fb9b72f0ccb8510e5ded7b6e83ba7","ref":"refs/heads/main","pushedAt":"2024-07-08T17:33:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add REFINE_TYPE for array construction\n\nSummary: Adds a `REFINE_TYPE` after array construction so the JIT knows we'll have an array.\n\nReviewed By: alexmalyshev\n\nDifferential Revision: D59337676\n\nfbshipit-source-id: 18d5ba20b24cdbf1c2034d1027a4bf26939a5c64","shortMessageHtmlLink":"Add REFINE_TYPE for array construction"}},{"before":"d84106ca8441ead6b11c383817ff32ab15fca767","after":"9a01a1262d3654529c2d714ad290b26816c6f943","ref":"refs/heads/main","pushedAt":"2024-07-08T16:47:35.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Use function to get dictionaries from types\n\nSummary:\nIn 3.12 the place to get dicts for builtin types is the interperter data and functions have been added to abstract this.\n\nThis diff mostly dumbly replaces direct reference in CinderX to `PyTypeObject::tp_dict` with `_PyType_GetDict()` (which returns a borrowed type). To keep the code clean I've added a macro to `py-portability.h` that just directly accesses the field for 3.10 use.\n\nReviewed By: alexmalyshev\n\nDifferential Revision: D59143468\n\nfbshipit-source-id: 2e8c2ee3ec4e606b2ac98b591ff8be65df05ea13","shortMessageHtmlLink":"Use function to get dictionaries from types"}},{"before":"3a3eb548de8bb595ccef2d6b8d56af497a39e613","after":"d84106ca8441ead6b11c383817ff32ab15fca767","ref":"refs/heads/main","pushedAt":"2024-07-03T23:07:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Don't use pycore_atomic.h in CinderX\n\nSummary:\nIt's an internal header and it conflicts with the standard C++ `atomic` header.\nThe only place we're using it is in ParallelGC, which isn't upstreamed yet.\nWhen we do try to upstream it, we'll need to switch over to the new `pyatomic.h`\nheader anyway (not available in the 3.12 branch).\n\nFor now use the stdatomic.h header directly in parallel_gc.c.\n\nReviewed By: jbower-fb\n\nDifferential Revision: D59341494\n\nfbshipit-source-id: 2a51caf80013acdc84364f4da9cd952ca31973d3","shortMessageHtmlLink":"Don't use pycore_atomic.h in CinderX"}},{"before":"a94ae7ddd4ad9186ee76c7ea6a715c3ee6cb7d95","after":"3a3eb548de8bb595ccef2d6b8d56af497a39e613","ref":"refs/heads/main","pushedAt":"2024-07-03T21:51:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Create PyUnstable_Code_New() wrapper for 3.10\n\nSummary:\nIn 3.10 this is called `PyCode_New()`, and it is missing the `qualname` and\n`exceptiontable` arguments.  CinderX only uses it for some unittests, so this\ndoesn't make any effort to make use of the new arguments if they are set in\n3.10.  In fact if they're set we should crash or warn the user somehow.\n\nReviewed By: jbower-fb\n\nDifferential Revision: D59342919\n\nfbshipit-source-id: fb6716bb7a494b8e4a39617523df253b0111651d","shortMessageHtmlLink":"Create PyUnstable_Code_New() wrapper for 3.10"}},{"before":"6c52afa5a1aea81223a57070d714e659f77907e6","after":"a94ae7ddd4ad9186ee76c7ea6a715c3ee6cb7d95","ref":"refs/heads/main","pushedAt":"2024-07-03T19:52:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Separate out many more cinderx/Jit/ rules\n\nSummary:\nMost of these are straightforward now.  The parser library is special in that it\ngets completed removed from //cinderx/Jit:Jit because a) it depends on\n//cinderx/StaticPython:StaticPython and b) it's only used by tests and not the\ncore extension.\n\nDifferential Revision: D58297260\n\nfbshipit-source-id: f06ca0b5bb736acf738f88b773f92d35c0cac99d","shortMessageHtmlLink":"Separate out many more cinderx/Jit/ rules"}},{"before":"5d7f72df3bef2e7aab721a9655bd70ac2a0ae956","after":"6c52afa5a1aea81223a57070d714e659f77907e6","ref":"refs/heads/main","pushedAt":"2024-07-03T18:32:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Separate out _PyTypedArgsInfo from the Static Python classloader\n\nSummary:\nTrying to reduce how much of the Static Python headers are pulled into the JIT.\nJit/jit_rt.h has been broken out into its own library to make it easier to\nmodularize the rest of the JIT, but it depends on _PyTypedArgsInfo which\ncurrently means pulling in all of the Static Python headers.\n\nDifferential Revision: D58291887\n\nfbshipit-source-id: 86680ca34b9c9e88fe67fd9d5d405291066d5d48","shortMessageHtmlLink":"Separate out _PyTypedArgsInfo from the Static Python classloader"}},{"before":"2c444d8a70eefac8d4286d0aaa392c98f25f21e9","after":"5d7f72df3bef2e7aab721a9655bd70ac2a0ae956","ref":"refs/heads/main","pushedAt":"2024-07-03T17:42:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Allow switching VSCode LSP to 3.12\n\nReviewed By: alexmalyshev\n\nDifferential Revision: D58709160\n\nfbshipit-source-id: 7ee555c871c8d7f97f3d493ccf8a1d7f07232552","shortMessageHtmlLink":"Allow switching VSCode LSP to 3.12"}},{"before":"2e77de4578464bbc0a5075893122f064c3e6c7d8","after":"2c444d8a70eefac8d4286d0aaa392c98f25f21e9","ref":"refs/heads/main","pushedAt":"2024-07-03T15:54:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add missing Pyre mode headers] [batch:3/25] [shard:2/N]\n\nReviewed By: connernilsen\n\nDifferential Revision: D59319811\n\nfbshipit-source-id: ee628d49980e81e7aa267778db739df358554e20","shortMessageHtmlLink":"Add missing Pyre mode headers] [batch:3/25] [shard:2/N]"}},{"before":"c59efb87ba99105d6a972b84132fb79ac7f13c7f","after":"2e77de4578464bbc0a5075893122f064c3e6c7d8","ref":"refs/heads/main","pushedAt":"2024-07-02T20:25:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add copyright headers to two stub files\n\nSummary: 2 stub files are still missing copyright headers. This adds them.\n\nReviewed By: pilleye\n\nDifferential Revision: D59281810\n\nfbshipit-source-id: 0eb34c7307aeee579b221ec63a843850efaa491c","shortMessageHtmlLink":"Add copyright headers to two stub files"}},{"before":"6c54cf436d5e8051548a830e542d30d291781b30","after":"c59efb87ba99105d6a972b84132fb79ac7f13c7f","ref":"refs/heads/main","pushedAt":"2024-07-02T19:17:11.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Separate out cinderx/Jit/debug_info.h into its own library\n\nSummary:\nThere's a bit of hackery happening here with how we need to create a new library\njust for the Jit/jit_rt.h header but not including the Jit/jit_rt.cpp\nimplementation file.  This is unavoidable right now because of the cyclical\ndependencies between Jit/ and StaticPython/.  At least now\n`//cinderx/Jit/hir:core` only needs the new `//cinderx/Jit:jit-rt-header` rule\ninstead of all of `//cinderx/Jit:Jit-headers`.\n\nReviewed By: brittanyrey\n\nDifferential Revision: D58291865\n\nfbshipit-source-id: 301cf668cd222d4f5268dfd80fdf61e4683aced3","shortMessageHtmlLink":"Separate out cinderx/Jit/debug_info.h into its own library"}},{"before":"e65724a7bd1a69954456529a23ab1cf071d50a7e","after":"6c54cf436d5e8051548a830e542d30d291781b30","ref":"refs/heads/main","pushedAt":"2024-07-02T16:20:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add more copyright headers\n\nSummary:\nThe repo checkup UI shows only a single file that's missing a copyright header - so D59164190 was missing lots of files. You need to kick off a run and look at the resulting email to get the full list. Hopefully this catches them all.\n\nLargely generated with `scripts/torchmultimodal/add_copyright_header.sh` modified to target our directory and our current style of copyright headers. Applied manual fixups for headers which should be \"Portions ...\" as they originated from external sources (e.g. checked list, portions of the compiler). Manually fixed up copyright headers around shebang lines. And C/C++ files were manually updated.\n\nDifferential Revision: D59235018\n\nfbshipit-source-id: 4d1b055690478cbbee29ab2f300e5496ff4d8538","shortMessageHtmlLink":"Add more copyright headers"}},{"before":"22b6dae1346e866fd28b7c599c2193dcb3abb95e","after":"e65724a7bd1a69954456529a23ab1cf071d50a7e","ref":"refs/heads/main","pushedAt":"2024-07-02T15:10:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Separate out the core LIR definitions into their own library\n\nSummary:\nSo that we're not globbing all the LIR files together.  The concepts of Block,\nFunction, Instruction, and Operand are difficult to tease apart, so they'll\nremain together for the near future.\n\nThe stuff with lir::Printer doesn't need to be here, and it ultimately pulls in\nthe HIRPrinter so we should definitely keep them separate.\n\nReviewed By: DinoV\n\nDifferential Revision: D58258091\n\nfbshipit-source-id: 8bbde4bd3f3453fdaab0dcaacb88eddb3b4fb006","shortMessageHtmlLink":"Separate out the core LIR definitions into their own library"}},{"before":"3f116e0d8c255058e7e9e925c8fa5d4e3f54518c","after":"22b6dae1346e866fd28b7c599c2193dcb3abb95e","ref":"refs/heads/main","pushedAt":"2024-07-02T06:48:53.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Replace Ci_cinderx_initialized with CinderX module variable\n\nSummary:\nIn 3.10 we had a hook to determine if the CinderX module had been initialized. This was most easily implemented as a global native variable as it was checked in the Cinder/CPython runtime. With CinderX hopefully we won't need need any checks in the base CPython runtime, so we can use a module variable which is a bit neater.\n\nIdeally we'd eliminate the `Ci_cinderx_initialized` for 3.10 as well but checking a module attribute in the middle of the runtime feels sketchy. I also explored making a global `Ci_cinderx_initialized` variable for use across the CinderX modules in 3.12 but this gets messy. I think it needs to use weak symbols to work, but I couldn't quite get them to do what I wanted. The module variable approach is certainly easy to get to work and understand.\n\nReviewed By: alexmalyshev\n\nDifferential Revision: D59135916\n\nfbshipit-source-id: 528377f0fbc98a92ea2d2180586c57cac70fdaa7","shortMessageHtmlLink":"Replace Ci_cinderx_initialized with CinderX module variable"}},{"before":"9007243b043c186f7415bbcd5e23936a5aaf249e","after":"3f116e0d8c255058e7e9e925c8fa5d4e3f54518c","ref":"refs/heads/main","pushedAt":"2024-07-02T03:52:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Make testcorpus tests run through buck2 test\n\nSummary: The `testcorpus` tests are similar to the sbs code tests but they're used for doing 100% matches but are simpler to debug than the std lib SBS tests. This just adds a new buck target so that we can easily run these stand alone.\n\nReviewed By: brittanyrey\n\nDifferential Revision: D59239748\n\nfbshipit-source-id: a7067e02101b97f7fb80f20c36917ee543d0cf5a","shortMessageHtmlLink":"Make testcorpus tests run through buck2 test"}},{"before":"07fed075dc1cef84087de2369f9c28ba290544ae","after":"9007243b043c186f7415bbcd5e23936a5aaf249e","ref":"refs/heads/main","pushedAt":"2024-07-01T22:24:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unneeded CHANGED_PYCODEOBJECT checks\n\nSummary:\nThese go away now that we have stubs for the `PyCode_*` functions.\n\nThere are still other legitimate uses of the assert (e.g. `co_cell2arg` usage)\nso we can't delete them all just yet.\n\nReviewed By: brittanyrey\n\nDifferential Revision: D59233049\n\nfbshipit-source-id: a4f7d5b1c9c1fabdba9211ec136527060835798b","shortMessageHtmlLink":"Remove unneeded CHANGED_PYCODEOBJECT checks"}},{"before":"4861131c9838cb08f01c12e63c14bd4b9d305aa4","after":"07fed075dc1cef84087de2369f9c28ba290544ae","ref":"refs/heads/main","pushedAt":"2024-07-01T20:51:42.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Run clang-format on Jit/lir/generator.cpp\n\nSummary: We've accumulated a number of lines that aren't autoformatted.\n\nDifferential Revision: D59169442\n\nfbshipit-source-id: 691e847368951c589d9d25f5a7b7b45305103a5d","shortMessageHtmlLink":"Run clang-format on Jit/lir/generator.cpp"}},{"before":"27c5ccd51660e2f5b97dddb79b3cd7c008f8b66c","after":"4861131c9838cb08f01c12e63c14bd4b9d305aa4","ref":"refs/heads/main","pushedAt":"2024-07-01T19:38:23.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Disable facebook-hte-NullableReturn lint\n\nReviewed By: alexmalyshev\n\nDifferential Revision: D59177666\n\nfbshipit-source-id: a02ea9302856b3a66730fbc28e3ec8b95bf3277f","shortMessageHtmlLink":"Disable facebook-hte-NullableReturn lint"}},{"before":"f06c4fd887d092af47ccb4eea871b592569198be","after":"27c5ccd51660e2f5b97dddb79b3cd7c008f8b66c","ref":"refs/heads/main","pushedAt":"2024-07-01T18:51:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add null-check for CiExc_StaticTypeError\n\nSummary: doeswhatitsaysonthetin\n\nReviewed By: alexmalyshev\n\nDifferential Revision: D59227718\n\nfbshipit-source-id: 025e9abb0935012f9ccdda723bfa153010e433a6","shortMessageHtmlLink":"add null-check for CiExc_StaticTypeError"}},{"before":"617c2b05e328e240519254ec6bf65a77da420f97","after":"f06c4fd887d092af47ccb4eea871b592569198be","ref":"refs/heads/main","pushedAt":"2024-06-28T23:16:22.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add missing copyright header\n\nSummary: The automated checkup tool found a file w/o a copyright header. Add the header.\n\nDifferential Revision: D59164190\n\nfbshipit-source-id: c75d0ea698dbe1ec0af69aa1027e732326e0a176","shortMessageHtmlLink":"Add missing copyright header"}},{"before":"594b6158b731af36c9713f21f7c91701dd2862be","after":"617c2b05e328e240519254ec6bf65a77da420f97","ref":"refs/heads/main","pushedAt":"2024-06-28T21:16:59.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Introduce UPGRADE_NOTE() and use for EXPORT_JIT_OFFSETS_FOR_STROBELIGHT\n\nSummary:\nThis is similar in spirit to `UPGRADE_ASSERT()` but doesn't actually assert. Instead it provides a \"structured comment\" we can grep for, strongly pushing the author to add a task. It could also be upgraded to an assert in future when trying to thrash out the long tail of issues.\n\nThis should be used sparingly as overuse will lead to hard to debug crashes. However, it can be useful to quickly unblock things. In this case `EXPORT_JIT_OFFSETS_FOR_STROBELIGHT` only matters when PyPerf is in use and perhaps isn't even needed for that anymore.\n\nReviewed By: alexmalyshev\n\nDifferential Revision: D58709161\n\nfbshipit-source-id: 4923ba763c728f980e092efce914bc62fb029e05","shortMessageHtmlLink":"Introduce UPGRADE_NOTE() and use for EXPORT_JIT_OFFSETS_FOR_STROBELIGHT"}},{"before":"bdff31dd3661929498098bafcd9cfdcc87315f3a","after":"594b6158b731af36c9713f21f7c91701dd2862be","ref":"refs/heads/main","pushedAt":"2024-06-28T14:39:16.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Hide implementation details of LIR rewrites\n\nSummary:\nCurrently they're all listed as static functions on their respective Rewrite\nsubclasses.  However they're only used within their respective implementation\nfiles, so they can all be moved into freestanding functions in an anonymous\nnamespace.\n\nDifferential Revision: D59125274\n\nfbshipit-source-id: fa7793a37ddec8b6b602c15b867169fed2cf0616","shortMessageHtmlLink":"Hide implementation details of LIR rewrites"}},{"before":"98d16411a0078d27780124576011e7b0d06d7270","after":"bdff31dd3661929498098bafcd9cfdcc87315f3a","ref":"refs/heads/main","pushedAt":"2024-06-27T20:39:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Enforce types flowing to hir::Return are <= the function's return type\n\nSummary:\n- add register type to Return instruction\n- check types <= the function's expected return type.\n\nReviewed By: alexmalyshev\n\nDifferential Revision: D57649604\n\nfbshipit-source-id: 40ca68975fd9ebaeea2cf8c480512243ffd63cd3","shortMessageHtmlLink":"Enforce types flowing to hir::Return are &lt;= the function's return type"}},{"before":"7778bd2c95b6ccd155201a42bae6f7b9bcf46278","after":"98d16411a0078d27780124576011e7b0d06d7270","ref":"refs/heads/main","pushedAt":"2024-06-27T17:35:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove DynamicComparisonElimination::ReplaceVectorCall\n\nSummary: As titled, this diff is to remove DynamicComparisonElimination::ReplaceVectorCall as part of the effort to get rid of the whole DynamicComparisonElimination class.\n\nReviewed By: alexmalyshev\n\nDifferential Revision: D59027114\n\nfbshipit-source-id: 8c8c55a53d74d94c1b2c5ca9bc7b94060bb80159","shortMessageHtmlLink":"Remove DynamicComparisonElimination::ReplaceVectorCall"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEeyjGRAA","startCursor":null,"endCursor":null}},"title":"Activity · facebookincubator/cinderx"}