Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel 7 Umbrella #2391

Closed
3 tasks
gaearon opened this issue May 27, 2017 · 10 comments
Closed
3 tasks

Babel 7 Umbrella #2391

gaearon opened this issue May 27, 2017 · 10 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented May 27, 2017

Want to start documenting things we need to do when Babel 7 is ready.

@gaearon gaearon added this to the 100.0.0 milestone May 27, 2017
@Timer
Copy link
Contributor

Timer commented May 28, 2017

We'll want to import babel-polyfill by default if we turn useBuiltIns to true.

@gaearon
Copy link
Contributor Author

gaearon commented May 28, 2017

Which features would depend on them? I just want to externalize helpers without bringing the whole core-js with them.

@Timer
Copy link
Contributor

Timer commented May 28, 2017

useBuiltIns transforms babel-polyfill into only the language features used in the app, babel-polyfill would become a single core-js import of Map if that's the only feature used.

@Timer
Copy link
Contributor

Timer commented May 28, 2017

To clarify, I made the suggestion to make the development experience nicer; not that we need it.

@gaearon
Copy link
Contributor Author

gaearon commented May 28, 2017

Hmm, that's not the part of useBuiltins I'm interested in. IMO trying to guess needed features by code is always lossy ([].includes) and we shouldn't attempt that.

The thing I'm interested in is deduplicating Babel helpers like _createClass. It's possible today with helpers: true but this brings in core-js due to how Babel worked (babel/babel#4418). As I understand this is now fixed.

@Timer
Copy link
Contributor

Timer commented May 28, 2017

IMO trying to guess needed features by code is always lossy ([].includes) and we shouldn't attempt that.

This works in Babel 7 from what I was told. As does many other really obscure cases:

'abc'['inclu' + 'des']('a')

I haven't actually tested this myself, but it would be sweet if it did.


Unfortunately, I don't think we can opt-out of this behavior for end-users that end up requiring babel-polyfill. Is useBuiltins required as part of deduping these helpers?

@badsyntax
Copy link

badsyntax commented Nov 4, 2017

This works in Babel 7 from what I was told. As does many other really obscure cases:

I put together an example project showing how this works, by using the "useBuiltIns": "usage" option of @babel/env: https://github.com/badsyntax/babel-builtin-polyfills

@gaearon
Copy link
Contributor Author

gaearon commented Nov 15, 2017

Now might be a good time to start trying Babel 7 and looking out for issues.

@clemmy clemmy mentioned this issue Nov 30, 2017
7 tasks
@gaearon gaearon modified the milestones: 100.0.0, 2.0.0 Jan 8, 2018
@rovansteen
Copy link
Contributor

https://babeljs.io/blog/2018/08/27/7.0.0 looks like the moment is finally there 💯

@RIP21
Copy link

RIP21 commented Aug 28, 2018

I think that Babel 7 being in beta was the biggest blocker to release version 2.0.0.
Any chances to make version 2.0.0 happened this September?
I see there is a lot of tasks open, but can't they be postponed for future 2.x.x versions?

@Timer Timer modified the milestones: 2.0.x, 2.x, 2.0.0 Sep 26, 2018
@Timer Timer closed this as completed Sep 26, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants