Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Configuration -> Convention over Configuration #1031

Merged
merged 1 commit into from
Nov 20, 2016

Conversation

sheerun
Copy link
Contributor

@sheerun sheerun commented Nov 10, 2016

This rule seems to be limiting development of this package. While it's certainly better to provide ready-to-use module that one doesn't need to configure, preventing configuration all together is constraining developers, forcing them to develop workarounds.

Besides this rule is already broken with NODE_ENV and proxy configuration and will be with plugins and PUBLIC_URL, BROWSER, browsers in package.json, and many others.

@gaearon gaearon merged commit 6fca0fe into facebook:master Nov 20, 2016
@gaearon
Copy link
Contributor

gaearon commented Nov 20, 2016

👍

jarlef pushed a commit to jarlef/create-react-app that referenced this pull request Nov 28, 2016
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants