Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds to docs - deployment with S3/CloudFront #1071

Merged
merged 2 commits into from
Nov 20, 2016

Conversation

wolovim
Copy link
Contributor

@wolovim wolovim commented Nov 20, 2016

What's this PR do?

Adds documentation for deploying to AWS S3 and CloudFront.

Any background context you want to provide?

Just a link to a blog post I wrote on the subject. This change was requested by @gaearon in issue #997.

What gif best describes this PR or how it makes you feel?

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@gaearon gaearon merged commit 29299f2 into facebook:master Nov 20, 2016
@gaearon
Copy link
Contributor

gaearon commented Nov 20, 2016

LGTM!

jarlef pushed a commit to jarlef/create-react-app that referenced this pull request Nov 28, 2016
* Adds to docs - deployment with S3/CloudFront

* Tweaks
@fson fson added this to the 0.8.0 milestone Dec 3, 2016
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
* Adds to docs - deployment with S3/CloudFront

* Tweaks
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
* Adds to docs - deployment with S3/CloudFront

* Tweaks
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants