Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update extract-text-webpack-plugin to stable #1700

Merged
merged 1 commit into from
Mar 2, 2017
Merged

Update extract-text-webpack-plugin to stable #1700

merged 1 commit into from
Mar 2, 2017

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Mar 2, 2017

@SimenB SimenB mentioned this pull request Mar 2, 2017
Merged
10 tasks
@gaearon gaearon added this to the 0.10.0 milestone Mar 2, 2017
@bondz
Copy link
Contributor

bondz commented Mar 2, 2017

Would it check off any of the tasks in #1668?

@Timer
Copy link
Contributor

Timer commented Mar 2, 2017 •
edited
Loading

@bondz no, they released extract-text-webpack-plugin as stable before it was stable. 🤷‍♀️

@Timer
Copy link
Contributor

Timer commented Mar 2, 2017

Thanks for the update, @SimenB. Have you tested the latest version still works? If not, I can test it tonight. Thanks!

@SimenB
Copy link
Contributor Author

SimenB commented Mar 2, 2017

I have not tested it, no. This is just submitted through the GH UI

@Timer
Copy link
Contributor

Timer commented Mar 2, 2017

Eh, it's in master anyway -- I'm sure it's fine. Thanks!
famous last words

@Timer Timer merged commit 45d1d24 into facebook:master Mar 2, 2017
@Timer
Copy link
Contributor

Timer commented Mar 2, 2017

Hm, not sure if this should be tagged internal or enhancement or nothing. /cc @gaearon

@gaearon
Copy link
Contributor

gaearon commented Mar 2, 2017

Internal is fine.

@SimenB SimenB deleted the patch-1 branch March 2, 2017 16:29
sbuzonas pushed a commit to sbuzonas/react-scripts that referenced this pull request May 5, 2017
@SimenB @Timer
Update extract-text-webpack-plugin to latest (facebook#1700)
fb87c80
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: internal
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@SimenB @bondz @Timer @gaearon @facebook-github-bot