add double quotes to escape spaces in paths in e2e

[viankakrisna]

Plans to fix #1652
This happens when you clone create-react-app to a path where it has spaces in any of the parent foldes.

To test it, just rename your parent folder to something with spaces and run npm run e2e

[Timer]

Can you add a test case within installs for this please?

[viankakrisna]

@Timer I'm not sure what you mean, can you elaborate?

[Timer]

Total facepalm moment, this is a problem with tests not anything else ... my bad haha.
^{Why not test tests?}

Thanks! Will merge once AppVeyor is green. 😄

[viankakrisna]

@Timer 😄 This pr still not working though, see below

[viankakrisna]

This line here still causes error even when wrapped with ""

here's the full log

Compiled successfully!

The app is running at:

  http://localhost:3000/

Note that the development build is not optimized.
To create a production build, use npm run build.

+ cd '/Users/adeviankakrisnafadlil/Local Sites/create-react-app-extra/packages/create-react-app'
++ npm pack
+ cli_path='/Users/adeviankakrisnafadlil/Local Sites/create-react-app-extra/packages/create-react-app/create-react-app-1.2.1.tgz'
+ cd '/Users/adeviankakrisnafadlil/Local Sites/create-react-app-extra/packages/react-scripts'
+ cp package.json package.json.orig
+ node '/Users/adeviankakrisnafadlil/Local Sites/create-react-app-extra/tasks/replace-own-deps.js'
Replaced local dependencies.
++ npm pack
+ scripts_path='/Users/adeviankakrisnafadlil/Local Sites/create-react-app-extra/packages/react-scripts/react-scripts-0.9.3.tgz'
+ rm package.json
+ mv package.json.orig package.json
+ cd /var/folders/f9/35kw1ffx64944m7ws1k3ytqh0000gn/T/tmp.VTXHaGfC
+ npm install '/Users/adeviankakrisnafadlil/Local Sites/create-react-app-extra/packages/create-react-app/create-react-app-1.2.1.tgz'
/private/var/folders/f9/35kw1ffx64944m7ws1k3ytqh0000gn/T/tmp.VTXHaGfC
└─┬ create-react-app@1.2.1 
  ├─┬ chalk@1.1.3 
  │ ├── ansi-styles@2.2.1 
  │ ├── escape-string-regexp@1.0.5 
  │ ├─┬ has-ansi@2.0.0 
  │ │ └── ansi-regex@2.1.1 
  │ ├── strip-ansi@3.0.1 
  │ └── supports-color@2.0.0 
  ├─┬ commander@2.9.0 
  │ └── graceful-readlink@1.0.1 
  ├─┬ cross-spawn@4.0.2 
  │ ├─┬ lru-cache@4.0.2 
  │ │ ├── pseudomap@1.0.2 
  │ │ └── yallist@2.0.0 
  │ └─┬ which@1.2.12 
  │   └── isexe@1.1.2 
  ├─┬ fs-extra@1.0.0 
  │ ├── graceful-fs@4.1.11 
  │ ├── jsonfile@2.4.0 
  │ └── klaw@1.3.1 
  ├── semver@5.3.0 
  └─┬ validate-npm-package-name@3.0.0 
    └── builtins@1.0.3 

npm WARN enoent ENOENT: no such file or directory, open '/private/var/folders/f9/35kw1ffx64944m7ws1k3ytqh0000gn/T/tmp.VTXHaGfC/package.json'
npm WARN tmp.VTXHaGfC No description
npm WARN tmp.VTXHaGfC No repository field.
npm WARN tmp.VTXHaGfC No README data
npm WARN tmp.VTXHaGfC No license field.
+ cd /var/folders/f9/35kw1ffx64944m7ws1k3ytqh0000gn/T/tmp.8YzQUV2S
+ create_react_app '--scripts-version=/Users/adeviankakrisnafadlil/Local Sites/create-react-app-extra/packages/react-scripts/react-scripts-0.9.3.tgz' test-app
+ node /var/folders/f9/35kw1ffx64944m7ws1k3ytqh0000gn/T/tmp.VTXHaGfC/node_modules/create-react-app/index.js --scripts-version=/Users/adeviankakrisnafadlil/Local Sites/create-react-app-extra/packages/react-scripts/react-scripts-0.9.3.tgz test-app
Creating a new React app in /private/var/folders/f9/35kw1ffx64944m7ws1k3ytqh0000gn/T/tmp.8YzQUV2S/Sites/create-react-app-extra/packages/react-scripts/react-scripts-0.9.3.tgz.

Installing packages. This might take a couple minutes.
Installing react, react-dom, and /Users/adeviankakrisnafadlil/Local...

yarn add v0.21.3
info No lockfile found.
[1/4] 🔍  Resolving packages...
error Couldn't find package "/Users/adeviankakrisnafadlil/Local" on the "npm" registry.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

Aborting installation.
  yarnpkg add --exact react react-dom /Users/adeviankakrisnafadlil/Local has failed.

Deleting generated file... package.json
Deleting react-scripts-0.9.3.tgz/ from /private/var/folders/f9/35kw1ffx64944m7ws1k3ytqh0000gn/T/tmp.8YzQUV2S/Sites/create-react-app-extra/packages/react-scripts
Done.
++ set +x
e2e-simple.sh: ERROR! An error was encountered executing line 159.
Cleaning up.
Exiting with error.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

It calls create-react-app in the packages folders and somehow failed to resolve proper path.

[Timer]

Does this work with npm? Might be a yarn bug.

[viankakrisna]

how to test it with npm? can i disable yarn temporarily on my machine?

[Timer]

Probably a bug here, not sure tho: https://github.com/viankakrisna/create-react-app/blob/759abc1fc4b8e87b14835482d0b25cafc070743d/packages/create-react-app/index.js#L182 We might need to wrap deps in quotes/apostrophes. I assumed that node handled this.

[viankakrisna]

Here's the problem, by the time it reach here https://github.com/viankakrisna/create-react-app/blob/759abc1fc4b8e87b14835482d0b25cafc070743d/packages/create-react-app/index.js#L115 program.scriptsVersion already stripped out the path after spaces.
I think the problem is in the bash. Will continue investigating it tonight...

[n3tr]

Change $* to "$@" on
https://github.com/viankakrisna/create-react-app/blob/759abc1fc4b8e87b14835482d0b25cafc070743d/tasks/e2e-simple.sh#L45
works for me 😃

[viankakrisna]

@n3tr thank you! Its working. Care to explain why its working? 😄

edit: nevermind, found it here http://stackoverflow.com/questions/3008695/what-is-the-difference-between-and-in-bash

[viankakrisna]

need to do this for other *.sh files too

will push more when tests are finished (it's long...)

[viankakrisna]

got

Cleaning up.
+ ps -ef
+ grep react-scripts
+ grep -v grep
+ awk '{print $2}'
+ xargs kill -s 9
kill: unknown signal 9; valid signals:
hup int quit ill trap abrt emt fpe kill bus segv sys pipe alrm term urg
stop tstp cont chld ttin ttou io xcpu xfsz vtalrm prof winch info usr1 usr2
+ cd '/Users/adeviankakrisnafadlil/Local Sites/create-react-app-extra'
+ rm -rf /var/folders/f9/35kw1ffx64944m7ws1k3ytqh0000gn/T/tmp.WuwNcz01 /var/folders/f9/35kw1ffx64944m7ws1k3ytqh0000gn/T/tmp.GhgBFwTu

at the end of kitchensink test is this expected?

[Timer]

Yes that error is fine to ignore for now, there's an issue for it.

[viankakrisna]

Ok then, I think we are ready for it 👍

[gaearon]

Thanks!