Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Promise and fetch polyfills #235

Merged
merged 1 commit into from
Jul 27, 2016
Merged

Add Promise and fetch polyfills #235

merged 1 commit into from
Jul 27, 2016

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Jul 27, 2016

I used promise (maintained by @ForbesLindesay and widely used at Facebook) and fetch (pretty much standard in the community).

These will be included for everyone. In terms of size, it adds about 4kB min+gzip, and I think it’s a fair tradeoff for getting these features as baseline since they’re so commonly used in the React tutorials.

Promise rejection tracking is on in all environments. If it truly causes performance issues, we can disable it in production. However I wouldn’t expect it to: front-end code isn’t usually as Promise-heavy as Node. There’s a difference between using a Promise here and there, and creating thousands of Promises in tight loops or whatever it is that most benchmarks measure.

@ghost ghost added the CLA Signed label Jul 27, 2016
@gaearon gaearon mentioned this pull request Jul 27, 2016
@ForbesLindesay
Copy link
Contributor

Looks good to me 👍

@gaearon gaearon merged commit 6d7741e into master Jul 27, 2016
@gaearon gaearon deleted the polyfills branch July 27, 2016 12:04
@gaearon gaearon added this to the 0.2.0 milestone Jul 27, 2016
@gaearon gaearon mentioned this pull request Jul 27, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants