Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unscope detect-port #2483

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Unscope detect-port #2483

merged 1 commit into from
Jun 6, 2017

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Jun 6, 2017

This unscopes detect-port because the ecosystem is not yet ready for scoped packages.

@Timer Timer added this to the 1.0.8 milestone Jun 6, 2017
Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

@Timer Timer merged commit dc4ce60 into facebook:master Jun 6, 2017
@Timer Timer deleted the unscope branch June 6, 2017 18:02
@princed
Copy link

princed commented Jun 7, 2017

the ecosystem is not yet ready for scoped packages

@Timer Just out of curiosity, what do you mean by that?

@Timer
Copy link
Contributor Author

Timer commented Jun 7, 2017

Scoped packages are an npm (the CLI) feature but it seems every custom registry in existence doesn't support them yet.

paweljedrzejczyk pushed a commit to paweljedrzejczyk/create-react-app that referenced this pull request Jun 12, 2017
* Update Travis CI Node versions in User Guide (facebook#2454)

Removed Node v4 (CRA only supports Node >= 6)

* re-add storybook && update the documentation and links (facebook#2331)

* re-add storybook && update the documentation and links

* Change to new documentation domain

* Prioritize index.css over the implicit App.css (facebook#2470)

* Added NamedModulesPlugin in webpack.config.dev.js (facebook#2458)

* Added NamedModulesPlugin in webpack.config.dev.js

* Update webpack.config.dev.js

* Unscope detect-port (facebook#2483)

Resolves facebook#2481

* Update webpack links to point to webpack 2 (facebook#2492)

* Update README.md to make links to webpack point to webpack.js.org instead
  insteade of webpack 1 webpack.githup.io

* chore(templates): Move GitHub templates to hidden .github folder (facebook#2489)

* Fix minor docs typo (facebook#2500)

* Fix link to Storybook docs (facebook#2521)

* Simplify flow init docs (facebook#2522)

- Call `npm run flow --init` won't create a .flowconfig file, it should be `npm run flow init`
@gaearon gaearon mentioned this pull request Jun 28, 2017
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants