Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to href-no-hash eslint rule #3460

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Fix broken link to href-no-hash eslint rule #3460

merged 1 commit into from
Nov 17, 2017

Conversation

hazolsky
Copy link
Contributor

@hazolsky hazolsky commented Nov 17, 2017

This fixes the broken link to removed href-no-hash.md file, which is no longer available in the eslint-plugin-jsx-a11y plugin (since 6.0.0).

This fixes the broken link to removed `href-no-hash.md` file, that is no longer available in the [eslint-plugin-jsx-a11y](https://github.com/evcohen/eslint-plugin-jsx-a11y) plugin (since [6.0.0](https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/a14617528cda23c6c88902ace1d083e4e13ac271/CHANGELOG.md))
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer
Copy link
Contributor

Timer commented Nov 17, 2017

Great catch! Thanks. 😄

@Timer Timer merged commit 47af4b4 into facebook:master Nov 17, 2017
@Timer Timer added this to the 1.0.17 milestone Nov 17, 2017
@hazolsky hazolsky deleted the patch-1 branch November 17, 2017 13:22
placenamehere pushed a commit to automatastudios/create-react-app that referenced this pull request Nov 30, 2017
@gaearon gaearon mentioned this pull request Jan 15, 2018
Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018
This fixes the broken link to removed `href-no-hash.md` file, that is no longer available in the [eslint-plugin-jsx-a11y](https://github.com/evcohen/eslint-plugin-jsx-a11y) plugin (since [6.0.0](https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/a14617528cda23c6c88902ace1d083e4e13ac271/CHANGELOG.md))
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants