Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow error overlay to be unregistered #3474

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Nov 20, 2017

Seems we forgot to set the unregister function.

@Timer Timer added this to the 1.0.17 milestone Nov 20, 2017
@Timer Timer merged commit c789794 into facebook:master Nov 21, 2017
@Timer Timer deleted the patch-1 branch November 21, 2017 04:23
placenamehere pushed a commit to automatastudios/create-react-app that referenced this pull request Nov 30, 2017
@gaearon gaearon mentioned this pull request Jan 15, 2018
@gaearon
Copy link
Contributor

gaearon commented Jan 15, 2018

@ovidiuch
Copy link
Contributor

@gaearon thanks!

@jozsi time to unskip the test and uncomment the import react-cosmos/react-cosmos#535 🤘

@jozsi
Copy link

jozsi commented Jan 16, 2018

Thank you, @gaearon!

@skidding: done! react-cosmos/react-cosmos#574

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants