Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use safer/more aesthetic syntax for setting environment variables on Windows #3533

Merged

Conversation

cdanielsen
Copy link
Contributor

(Cleaned up version of #3530)

Documentation update to fix a maddeningly easy oversite for Windows users. The SET command allows for wrapping the variable assignment expression with double quotes. Using this method negates the need to smash two commands together with the && operator as currently documented.

@cdanielsen
Copy link
Contributor Author

@Timer any thoughts on this?

@Timer
Copy link
Contributor

Timer commented Jan 2, 2018

I like this. Thanks!

@Timer Timer added this to the 1.0.18 milestone Jan 2, 2018
@Timer Timer merged commit 76e3165 into facebook:master Jan 2, 2018
@cdanielsen cdanielsen deleted the improve-documentation-for-windows-users branch January 2, 2018 19:57
@gaearon gaearon mentioned this pull request Jan 15, 2018
Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018
* use safer/more aesthetic syntax

* fix typo
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Aug 14, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants