Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autodetect MacVim editor #3545

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Autodetect MacVim editor #3545

merged 1 commit into from
Jan 8, 2018

Conversation

gnapse
Copy link
Contributor

@gnapse gnapse commented Dec 4, 2017

Adds support for the error overlay to detect and open the file with the error in MacVim.

Relates to #2636.

@gnapse
Autodetect MacVim editor
ea702cb 
Adds support for the error overlay to detect and open the file with the error in MacVim.

Relates to #2636.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon added this to the 1.0.18 milestone Jan 8, 2018
@gaearon gaearon merged commit 1b067c5 into facebook:master Jan 8, 2018
@gaearon
Copy link
Contributor

gaearon commented Jan 8, 2018

Looks good, thanks!

@gnapse gnapse deleted the patch-1 branch January 9, 2018 01:45
@gaearon gaearon mentioned this pull request Jan 15, 2018
Merged
@gaearon
Copy link
Contributor

gaearon commented Jan 15, 2018

This is out in react-scripts@1.1.0! Please let us know if something doesn’t quite work.
https://github.com/facebookincubator/create-react-app/releases/tag/v1.1.0

@dependencies dependencies bot mentioned this pull request Jan 15, 2018
Merged
This was referenced Feb 2, 2018
Closed
Closed
Closed
Closed
Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018
@gnapse
Autodetect MacVim editor (facebook#3545)
6a83f43 
Adds support for the error overlay to detect and open the file with the error in MacVim.

Relates to facebook#2636.
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gnapse @facebook-github-bot @gaearon