Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Debugging Tests for VSCode #3605

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Conversation

amadeogallardo
Copy link
Contributor

The launch configuration code provided is not compatible with VSCode since version 1.19.
The proposed documentation change is based on the response by a VSCode team member.

References:
#3602 (comment)
microsoft/vscode#40293 (comment)

The launch configuration code provided is not compatible with VSCode since version 1.19.
The proposed documentation change is based on the response by a VSCode team member.

References:
facebook#3602 (comment)
microsoft/vscode#40293 (comment)
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer
Copy link
Contributor

Timer commented Dec 18, 2017

Cheers, thanks!

@Timer Timer added this to the 1.0.17 milestone Dec 18, 2017
@Timer Timer merged commit ed5c48c into facebook:master Dec 18, 2017
@amadeogallardo amadeogallardo deleted the patch-1 branch December 19, 2017 14:44
Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018
The launch configuration code provided is not compatible with VSCode since version 1.19.
The proposed documentation change is based on the response by a VSCode team member.

References:
facebook#3602 (comment)
microsoft/vscode#40293 (comment)
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Aug 14, 2018
The launch configuration code provided is not compatible with VSCode since version 1.19.
The proposed documentation change is based on the response by a VSCode team member.

References:
facebook#3602 (comment)
microsoft/vscode#40293 (comment)
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants