Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document configuration and build process #362

Merged
merged 1 commit into from
Aug 4, 2016
Merged

Document configuration and build process #362

merged 1 commit into from
Aug 4, 2016

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Aug 4, 2016

This seems like a nice thing to do since the user will have to deal with this after ejection.
Also serves as a good reminder for us in the future for why we made certain choices.

@ghost ghost added the CLA Signed label Aug 4, 2016
@gaearon gaearon force-pushed the document branch 3 times, most recently from 131b25b to 3246059 Compare August 4, 2016 19:34
@mxstbr
Copy link
Contributor

mxstbr commented Aug 4, 2016

Ace. :shipit:

@gaearon gaearon force-pushed the document branch 2 times, most recently from 8717c0f to 6c47426 Compare August 4, 2016 19:39
@pawelgrzybek
Copy link

Great idea Dan. Yes please!

@gaearon gaearon force-pushed the document branch 3 times, most recently from c321146 to a43fc43 Compare August 4, 2016 19:47
@ghost ghost added the CLA Signed label Aug 4, 2016
require.resolve('babel-plugin-transform-object-rest-spread'),
require.resolve('babel-plugin-transform-react-constant-elements'),
// function* () { yield 42; yield 43; }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaearon what is this for? (just curious 💭 )

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm it's an example of regenerator

@MoonTahoe
Copy link

I think this would be really a helpful point of reference for students.

@gaearon gaearon merged commit c1a984d into master Aug 4, 2016
@gaearon gaearon added this to the 0.3.0 milestone Aug 4, 2016
require.resolve('babel-plugin-transform-object-rest-spread'),
require.resolve('babel-plugin-transform-react-constant-elements'),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the only non-comment change in this PR, is it intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I just moved it a few lines down for consistency with dev config (order shouldn’t matter for this transform).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah i didn't see it, nevermind then 👍

@gaearon gaearon deleted the document branch August 4, 2016 20:13
tizmagik added a commit to tizmagik/create-react-app that referenced this pull request Aug 5, 2016
…react-app

* 'master' of https://github.com/facebookincubator/create-react-app:
  0.3.0-alpha
  Update some deps
  Document configuration and build process (facebook#362)

# Conflicts:
#	config/webpack.config.dev.js
gaearon added a commit that referenced this pull request Aug 22, 2016
@gaearon gaearon modified the milestones: 0.2.2, 0.3.0 Aug 22, 2016
@gaearon gaearon mentioned this pull request Aug 22, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants