Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend --scripts-version to include .tar.gz format #3725

Merged
merged 2 commits into from
Jan 9, 2018
Merged

Extend --scripts-version to include .tar.gz format #3725

merged 2 commits into from
Jan 9, 2018

Conversation

SaschaDens
Copy link
Contributor

Closes #3573

Added a minor change to allow .tar.gz extension for the --scripts-version CLI.
I didn't enable the .tar extension, It's supported by the package(tar-pack) but it seems not to be supported by Yarn.

Thanks!

@@ -487,6 +492,7 @@ function checkNodeVersion(packageName) {
packageName,
'package.json'
);
console.log(packageJsonPath);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops indeed, overlooked this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants