Always use Yarn on CI #3738
Merged
Always use Yarn on CI #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This was referenced Feb 2, 2018
Pavek
pushed a commit
to Pavek/create-react-app
that referenced
this pull request
Jul 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our E2E tests are in a very messy state right now. Due to a pile of hacks that accumulated over months, it's very hard to understand what's happening to the packages.
I want to simplify this. As a first step I want to get rid of this variable.
It looks like it's not actually being used. (The branch is always false.) And since Yarn now ships with CI images, we actually do use Yarn on CI already.
With this change, we're just eliminating already dead code. Next, I'll try to simplify the actual CI script, but for now I just want the code to reflect what it actually does because it wasn't obvious.