Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use private registry #3744

Merged
merged 3 commits into from
Jan 11, 2018
Merged

Use private registry #3744

merged 3 commits into from
Jan 11, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Jan 11, 2018

This removes a lot of the painful trickery we do via setting up a local registry and actually publishes the modules.

We can now test as if we're an end-user. This means our tests actually mean something now. 😄

verdaccio is used to spin up a lightweight local registry. It allows you to publish packages and uses npm as its fallback.
verdaccio supports an anonymous publishing mode, but I'd rather not ship a config file with this.
Since we use verdaccio's defaults, you must login to publish a package.

Due to long standing npm issue, we have to use npm-cli-login to login (over standard npm adduser).

Packages are released using our release.sh script.

The create_react_app function, our install_package npm link workaround, and npm pack of react-scripts are all gone 🎉.

In hindsight, I can't believe we ever did it different than this. Seriously.

@Timer Timer added this to the 1.0.18 milestone Jan 11, 2018
@ORESoftware
Copy link

include a link to verdaccio? google is broken for me right now

Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018
* Run e2e-simple in a realistic scenario

* Use npx for everything

* oops
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants