Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hash to media files even in the devmode. #446

Merged
merged 1 commit into from
Aug 15, 2016

Conversation

arunoda
Copy link
Contributor

@arunoda arunoda commented Aug 15, 2016

This will work correctly when there are duplicate filenames in different paths.
Fixes: #445

This will work correctly when there are duplicate filenames in different paths.
Fixes: facebook#445
@ghost ghost added the CLA Signed label Aug 15, 2016
@arunoda
Copy link
Contributor Author

arunoda commented Aug 15, 2016

I tried the fix by ejecting the app and it worked pretty well. Do you know how can I write tests for this?

@gaearon gaearon merged commit 7c912b5 into facebook:master Aug 15, 2016
@gaearon gaearon added this to the 0.3.0 milestone Aug 15, 2016
@gaearon
Copy link
Contributor

gaearon commented Aug 15, 2016

Thanks.

gaearon pushed a commit that referenced this pull request Aug 22, 2016
This will work correctly when there are duplicate filenames in different paths.
Fixes: #445
@gaearon gaearon modified the milestones: 0.2.2, 0.3.0 Aug 22, 2016
@gaearon gaearon mentioned this pull request Aug 22, 2016
stayradiated pushed a commit to stayradiated/create-react-app that referenced this pull request Sep 7, 2016
This will work correctly when there are duplicate filenames in different paths.
Fixes: facebook#445
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
This will work correctly when there are duplicate filenames in different paths.
Fixes: facebook#445
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants