Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate the new-cap rule in ESLint #470

Merged
merged 1 commit into from
Aug 22, 2016
Merged

Conversation

rricard
Copy link
Contributor

@rricard rricard commented Aug 22, 2016

This rule is considered dangerous in certain situations. This is especially true for Immutable.js users. See the discussion at issue #465 for more information about this.

Fixes #465

This rule is considered dangerous in certain situations. This is especially true for Immutable.js users. See the discussion at issue facebook#465 for more information about this.
@ghost ghost added the CLA Signed label Aug 22, 2016
@gaearon gaearon added this to the 0.3.0 milestone Aug 22, 2016
@gaearon gaearon merged commit 318c803 into facebook:master Aug 22, 2016
@gaearon
Copy link
Contributor

gaearon commented Aug 22, 2016

👍

@rricard rricard deleted the new-cap-off branch August 22, 2016 12:51
gaearon pushed a commit that referenced this pull request Aug 22, 2016
This rule is considered dangerous in certain situations. This is especially true for Immutable.js users. See the discussion at issue #465 for more information about this.
@gaearon gaearon modified the milestones: 0.2.1, 0.3.0, 0.2.2 Aug 22, 2016
@gaearon gaearon mentioned this pull request Aug 22, 2016
stayradiated pushed a commit to stayradiated/create-react-app that referenced this pull request Sep 7, 2016
This rule is considered dangerous in certain situations. This is especially true for Immutable.js users. See the discussion at issue facebook#465 for more information about this.
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
This rule is considered dangerous in certain situations. This is especially true for Immutable.js users. See the discussion at issue facebook#465 for more information about this.
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants