Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid tons of *.json.gzip-files created in project root when running with docker node #620

Merged
merged 2 commits into from
Sep 10, 2016

Conversation

thangngoc89
Copy link
Contributor

Fixes #483
Fixes #612

@ghost
Copy link

ghost commented Sep 10, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost
Copy link

ghost commented Sep 10, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon added this to the 0.4.2 milestone Sep 10, 2016
@ghost ghost added the CLA Signed label Sep 10, 2016
cacheDirectory: true,
// It enables caching results in ./node_modules/.cache/create-react-app/
// directory for faster rebuilds.
cacheDirectory: findCacheDir({ name: 'create-react-app' }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convention seems to be that this should be the project name from package.json. Since this file is used by react-scripts, should we use react-scripts as the name here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@thangngoc89
Copy link
Contributor Author

I updated the PR

@fson fson merged commit 6670291 into facebook:master Sep 10, 2016
@fson
Copy link
Contributor

fson commented Sep 10, 2016

I tested this using the offical Node Docker image and it works, the cache files were stored in node_modules/.cache/react-scripts instead of the project root.

Thanks for the PR @thangngoc89!

@lallmon
Copy link

lallmon commented Sep 17, 2016

When is the next release of this planned?

@gaearon
Copy link
Contributor

gaearon commented Sep 17, 2016

Within a few days.

@gaearon gaearon mentioned this pull request Sep 18, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 18, 2016

This should be fixed in 0.4.2.
Please verify!

@lallmon
Copy link

lallmon commented Sep 18, 2016

@gaearon Upgrade went smooth, and no gzip in my docker container. 👍

feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
…with docker node (facebook#620)

* Specify cache directory for babel loader

* Use `react-scripts` for folder name instead
fson added a commit to fson/create-react-app that referenced this pull request Oct 29, 2016
Upgrade `babel-loader` and remove the cache directory configuration
that was added in facebook#620. `babel-loader` now uses the
`./node_modules/.cache/babel-loader` directory by default, so the
custom config is no longer needed.
gaearon pushed a commit that referenced this pull request Oct 29, 2016
Upgrade `babel-loader` and remove the cache directory configuration
that was added in #620. `babel-loader` now uses the
`./node_modules/.cache/babel-loader` directory by default, so the
custom config is no longer needed.
jarlef pushed a commit to jarlef/create-react-app that referenced this pull request Nov 28, 2016
Upgrade `babel-loader` and remove the cache directory configuration
that was added in facebook#620. `babel-loader` now uses the
`./node_modules/.cache/babel-loader` directory by default, so the
custom config is no longer needed.
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
Upgrade `babel-loader` and remove the cache directory configuration
that was added in facebook#620. `babel-loader` now uses the
`./node_modules/.cache/babel-loader` directory by default, so the
custom config is no longer needed.
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
Upgrade `babel-loader` and remove the cache directory configuration
that was added in facebook#620. `babel-loader` now uses the
`./node_modules/.cache/babel-loader` directory by default, so the
custom config is no longer needed.
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants