Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audio support in url loader #665

Merged
merged 1 commit into from
Sep 17, 2016
Merged

Add audio support in url loader #665

merged 1 commit into from
Sep 17, 2016

Conversation

danharper
Copy link
Contributor

No description provided.

@ghost ghost added the CLA Signed label Sep 17, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 17, 2016

Can you also send a PR to https://github.com/scottcorgan/pushstate-server to support them please?
Just like scottcorgan/pushstate-server#21.

Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a PR to pushstate-server.

@danharper
Copy link
Contributor Author

Sure - on it now.

@danharper
Copy link
Contributor Author

danharper commented Sep 17, 2016

Looks like that project's recently released a new version which doesn't require any file extension whitelist - it just serves everything. Do you know what version of it is used? (can't find it in the package.json)

@gaearon
Copy link
Contributor

gaearon commented Sep 17, 2016

Haha, that’s cool.
We don’t explicitly depend on it, just include it in “how to serve build folder” instructions.
So it looks good then.

@gaearon gaearon added this to the 0.4.2 milestone Sep 17, 2016
@gaearon gaearon merged commit a5bf074 into facebook:master Sep 17, 2016
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants