Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Babel and ESLint config to package.json after ejecting #773

Merged
merged 1 commit into from
Sep 27, 2016

Conversation

montogeek
Copy link
Contributor

Implements #766

E2E test ran successfully on my computer.

While running it I discovered that https://github.com/facebookincubator/create-react-app/blob/master/tasks/e2e.sh#L187 does not work, the test ran in watch mode anyway.

@ghost ghost added the CLA Signed label Sep 27, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 27, 2016

Looks good to me, thanks!

@gaearon gaearon merged commit d72c749 into facebook:master Sep 27, 2016
@gaearon gaearon added this to the 0.7.0 milestone Sep 27, 2016
@wesbos
Copy link

wesbos commented Sep 27, 2016

@gaearon any ETA on releasing this? I'd love to show this in my Ejecting video, but I'm recording it today

@gaearon
Copy link
Contributor

gaearon commented Sep 27, 2016

OK, I’ll cut 0.6.1 😄

@gaearon gaearon modified the milestones: 0.6.1, 0.7.0 Sep 27, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 27, 2016

Out in 0.6.1, please verify!

@wesbos
Copy link

wesbos commented Sep 27, 2016

works great! Thank you sooooo much ❤️

kitze added a commit to kitze/custom-react-scripts that referenced this pull request Oct 3, 2016
…react-app

# By Dan Abramov (5) and others
# Via Dan Abramov
* 'master' of https://github.com/facebookincubator/create-react-app:
  docs(readme): peer dependencies applied (facebook#818)
  Fix typos on ISSUE_TEMPLATE.md (facebook#817)
  Add explicit linebreaks (facebook#813)
  Fix typo (facebook#810)
  Fix some typos (facebook#809)
  Beaufity output of eject.js script (facebook#769)
  Define process.env as object (facebook#807)
  Typo fix in webpack.config.dev.js comments (facebook#777)
  Add Netlify to deploy instructions
  Fix usage example to match react-dev-utils@0.2.x API
  Relaxed eslint rule no-unused-expressions (facebook#724)
  Fix the doc
  Publish
  Add 0.6.1 changelog
  Moved Babel and ESLint config to package.json after ejecting (facebook#773)

Conflicts:
	packages/react-scripts/package.json
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
maltestenzel pushed a commit to maltestenzel/custom-react-scripts that referenced this pull request Mar 7, 2018
…react-app

# By Dan Abramov (5) and others
# Via Dan Abramov
* 'master' of https://github.com/facebookincubator/create-react-app:
  docs(readme): peer dependencies applied (facebook#818)
  Fix typos on ISSUE_TEMPLATE.md (facebook#817)
  Add explicit linebreaks (facebook#813)
  Fix typo (facebook#810)
  Fix some typos (facebook#809)
  Beaufity output of eject.js script (facebook#769)
  Define process.env as object (facebook#807)
  Typo fix in webpack.config.dev.js comments (facebook#777)
  Add Netlify to deploy instructions
  Fix usage example to match react-dev-utils@0.2.x API
  Relaxed eslint rule no-unused-expressions (facebook#724)
  Fix the doc
  Publish
  Add 0.6.1 changelog
  Moved Babel and ESLint config to package.json after ejecting (facebook#773)

Conflicts:
	packages/react-scripts/package.json
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants