Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jest 16 #858

Merged
merged 2 commits into from
Oct 11, 2016
Merged

Upgrade to Jest 16 #858

merged 2 commits into from
Oct 11, 2016

Conversation

chase
Copy link
Contributor

@chase chase commented Oct 5, 2016

Resolves #851.

Looks like the only things requiring an update were babel-jest and jest in react-scripts.

This should probably be another issue for later, but:
The only things that I wasn't certain on is how the updated Snapshot Testing capabilities should be handled. The README template considers them experimental, but there was a pretty huge emphasis on the magic of snapshots in the v16 blog post.

@gaearon Is the only thing currently blocking adoption this issue?
facebook/react#7371

@chase
Copy link
Contributor Author

chase commented Oct 5, 2016

Also looks like Jest 16.0.1 will be cut soon with a bug fix, so I held off from doing a minor update to the package version for react-scripts.

@StevenACoffman StevenACoffman mentioned this pull request Oct 6, 2016
@gaearon
Copy link
Contributor

gaearon commented Oct 6, 2016

That's not the only issue but React 15.4.0 final will contain fixes for all major issues. We'll still need to add a traversal API but that would be the last missing bit and not essential.

@chase
Copy link
Contributor Author

chase commented Oct 8, 2016

Should be good to go with 16.0.1 now. Should I bump the react-scripts version by a minor version or would it be a revision in this case?

@gaearon
Copy link
Contributor

gaearon commented Oct 11, 2016

Don't worry about bumping package.json, we do this during the release.

@gaearon gaearon added this to the 0.7.0 milestone Oct 11, 2016
@gaearon gaearon merged commit 3539d04 into facebook:master Oct 11, 2016
@gaearon
Copy link
Contributor

gaearon commented Oct 11, 2016

Thanks!

feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
* Update react-scripts dependencies to use jest 16

* Remove testRegex from Jest config (now default)
jarlef pushed a commit to jarlef/create-react-app that referenced this pull request Nov 28, 2016
* Update react-scripts dependencies to use jest 16

* Remove testRegex from Jest config (now default)
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants