Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostCSS should run on @import statements. #929

Merged
merged 1 commit into from
Oct 19, 2016

Conversation

nhunzaker
Copy link
Contributor

Looks like PostCSS isn't running on stylesheets included via @import within another stylesheet. The postcss-loader docs use ?importLoaders=1 in there configuration. Adding it fixed the issue.

Steps to reproduce:

  1. Create a new app with create-react-app
  2. Import App.css from src/index.css
  3. Remove import './App.css' from src/App.js

The -webkit- prefix for the animation style rule is gone! I've pushed up an example here:

https://github.com/nhunzaker/no-autoprefixer-issue

@gaearon gaearon added this to the 0.7.0 milestone Oct 19, 2016
@gaearon
Copy link
Contributor

gaearon commented Oct 19, 2016

LGTM, thanks!

@gaearon gaearon merged commit 59acae6 into facebook:master Oct 19, 2016
arunoda added a commit to storybookjs/storybook that referenced this pull request Oct 24, 2016
arunoda added a commit to storybookjs/storybook that referenced this pull request Oct 24, 2016
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
jarlef pushed a commit to jarlef/create-react-app that referenced this pull request Nov 28, 2016
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants