Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback install tests are not covered in CI #11057

Closed
yingsu00 opened this issue Sep 21, 2024 · 4 comments
Closed

Fallback install tests are not covered in CI #11057

yingsu00 opened this issue Sep 21, 2024 · 4 comments
Labels
build triage Newly created issue that needs attention.

Comments

@yingsu00
Copy link
Collaborator

yingsu00 commented Sep 21, 2024

Problem description

In Upgrade FBOS dependencies to 2024.09.16.00, there was a URL error (missing ref/tags/) in fast_float.cmake (see #11056), but the CI didn't report any error (presuming all tests passed before merging).
Moreover, the CI also didn't catch the error running setup-macos.sh when installing fast_float.

Shall we add proper coverage testing the system setups?

System information

N/A

CMake log

No response

@yingsu00 yingsu00 added build triage Newly created issue that needs attention. labels Sep 21, 2024
@yingsu00
Copy link
Collaborator Author

@majetideepak
Copy link
Collaborator

@yingsu00 We should throw an error in such instances. I wonder how CI passed even though the dependency did not install.
The image build CI jobs should have failed.

@majetideepak
Copy link
Collaborator

majetideepak commented Sep 23, 2024

@czentgr is adding a bundled-only and scripts-only CI job for macos here #10670.
That should improve the coverage.

@assignUser
Copy link
Collaborator

As seen in #11056 the url without ref/tag also works but seems to have had some downtime when running this locally.
The reason why the docker ci didn't fail is because the install worked there.

We use set -e in the install scripts so any error while immediately kill the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build triage Newly created issue that needs attention.
Projects
None yet
Development

No branches or pull requests

3 participants