We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caught by IBM internal security scan.
AsynDataCache::canTryAllocate used int32_t as parameter type for numPages, https://github.com/facebookincubator/velox/blob/main/velox/common/caching/AsyncDataCache.cpp#L867, when parameter passed in was MachinePageCount (uint64_t) from AsyncDataCache::makeSpace https://github.com/facebookincubator/velox/blob/main/velox/common/caching/AsyncDataCache.cpp#L779
This could've caused crashes in production.
Have fixed the signature in #11684, but creating an issue to get broader consensus on the issue and fix.
Velox System Info v0.0.2 Commit: c14348e CMake Version: 3.31.0 System: Darwin-23.6.0 Arch: arm64 C++ Compiler: /Library/Developer/CommandLineTools/usr/bin/c++ C++ Compiler Version: 15.0.0.15000309 C Compiler: /Library/Developer/CommandLineTools/usr/bin/cc C Compiler Version: 15.0.0.15000309 CMake Prefix Path: /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr;/opt/homebrew;/usr/local;/usr;/;/opt/homebrew;/usr/local;/usr/X11R6;/usr/pkg;/opt;/sw;/opt/local
No response
The text was updated successfully, but these errors were encountered:
@majetideepak @Yuhta @xiaoxmeng
Sorry, something went wrong.
aditi-pandit
No branches or pull requests
Bug description
Caught by IBM internal security scan.
AsynDataCache::canTryAllocate used int32_t as parameter type for numPages, https://github.com/facebookincubator/velox/blob/main/velox/common/caching/AsyncDataCache.cpp#L867, when parameter passed in was MachinePageCount (uint64_t) from AsyncDataCache::makeSpace
https://github.com/facebookincubator/velox/blob/main/velox/common/caching/AsyncDataCache.cpp#L779
This could've caused crashes in production.
Have fixed the signature in #11684, but creating an issue to get broader consensus on the issue and fix.
System information
Velox System Info v0.0.2
Commit: c14348e
CMake Version: 3.31.0
System: Darwin-23.6.0
Arch: arm64
C++ Compiler: /Library/Developer/CommandLineTools/usr/bin/c++
C++ Compiler Version: 15.0.0.15000309
C Compiler: /Library/Developer/CommandLineTools/usr/bin/cc
C Compiler Version: 15.0.0.15000309
CMake Prefix Path: /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr;/opt/homebrew;/usr/local;/usr;/;/opt/homebrew;/usr/local;/usr/X11R6;/usr/pkg;/opt;/sw;/opt/local
Relevant logs
No response
The text was updated successfully, but these errors were encountered: