Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test utilities must be free from googletest dependency. #1739

Closed
majetideepak opened this issue May 31, 2022 · 1 comment
Closed

Test utilities must be free from googletest dependency. #1739

majetideepak opened this issue May 31, 2022 · 1 comment

Comments

@majetideepak
Copy link
Collaborator

majetideepak commented May 31, 2022

Test utilities should ideally contain helper classes to build other tests. Any testing should be done in the tests that invoke these util classes.
Example: velox/dwio/dwrf/test/utils/E2EWriterTestUtil.cpp does some test checks, which introduces a dependency on googletest. These checks must ideally be performed in the tests where the methods in utils/E2EWriterTestUtil.cpp are invoked. This helps with test readability as well as helps maintain clean dependencies.

@stale
Copy link

stale bot commented Sep 14, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Sep 14, 2022
@stale stale bot closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant