From 1642d5c11c9068c32b3adfd243d3d754956fba99 Mon Sep 17 00:00:00 2001 From: ruanchaves Date: Sat, 11 Jul 2020 14:34:49 -0300 Subject: [PATCH] bug fix: PARAMETERS in run_benchmark.py and kwargs in _load_candidates() call at main_dense.py --- blink/main_dense.py | 2 +- blink/run_benchmark.py | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/blink/main_dense.py b/blink/main_dense.py index e9e97da7..f59610d0 100644 --- a/blink/main_dense.py +++ b/blink/main_dense.py @@ -312,7 +312,7 @@ def load_models(args, logger=None): wikipedia_id2local_id, faiss_indexer, ) = _load_candidates( - args.entity_catalogue, args.entity_encoding, args.faiss_index, args.index_path, + args.entity_catalogue, args.entity_encoding, faiss_index=args.faiss_index, index_path=args.index_path, ) return ( diff --git a/blink/run_benchmark.py b/blink/run_benchmark.py index 552332fb..a5bd16a7 100644 --- a/blink/run_benchmark.py +++ b/blink/run_benchmark.py @@ -27,6 +27,8 @@ ] PARAMETERS = { + "faiss_index": None, + "index_path": None, "test_entities": None, "test_mentions": None, "interactive": False, @@ -38,6 +40,7 @@ "crossencoder_config": "models/crossencoder_wiki_large.json", "output_path": "output", "fast": False, + "top_k": 100, } args = argparse.Namespace(**PARAMETERS)