-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-scale feature extraction for image retrieval? #90
Comments
Hi @woctezuma We have not tried multi-scale feature extraction for k-NN. See https://github.com/filipradenovic/cnnimageretrieval-pytorch/blob/master/cirtorch/networks/imageretrievalnet.py#L309-L324 and https://github.com/filipradenovic/cnnimageretrieval-pytorch/blob/c5368dfbbfe0286f536e374a4a35ff89578ef2e5/cirtorch/examples/test.py#L53-L55 for example. |
Thank you for your answer. To be clear, are the image-retrieval results shown in the paper obtained with a single scale or with multiple scales? If multi-scale was used in the paper, you might want to set the default value to Line 86 in ba9edd1
|
Paris is with multi-scale, Oxford is without. Yes it is true that I have not provided much implementation details for this image retrieval benchmark in the paper but hopefully my implementation in this repo provides all the details for users to replicate the published numbers. |
Thank you. I had not noticed that the information was present in the command-line examples! |
Following #72, I have noticed that there is some code for multi-scale feature extraction:
dino/eval_knn.py
Lines 101 to 104 in ba9edd1
where three scales are used: 1, 1/sqrt(2), and 1/2.
dino/utils.py
Lines 795 to 809 in ba9edd1
I see that this piece of code was committed for image retrieval (rather than KNN even though it appears in the code for KNN).
However, I don't see it mentioned in the paper. Does it lead to better results for image retrieval?
The text was updated successfully, but these errors were encountered: