This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Refactor code in `/tasks/admin_or_owner` #895

Open

ktirumalafb opened this issue Feb 25, 2022 · 0 comments

Assignees

Contributor

ktirumalafb commented Feb 25, 2022

If you look here: https://github.com/facebookresearch/dynabench/blob/main/api/controllers/tasks.py#L241 the default is that we return True unless the if statements are satisfied, I think it should be the other way around (we start off with False and we return the user is an admin or owner only if the if statements are satisfied)

The text was updated successfully, but these errors were encountered:

ktirumalafb self-assigned this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.