Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Sync OSS.param_groups and the sharded optimizer param_groups #66

Closed
blefaudeux opened this issue Sep 5, 2020 · 0 comments · Fixed by #67
Closed

[feat] Sync OSS.param_groups and the sharded optimizer param_groups #66

blefaudeux opened this issue Sep 5, 2020 · 0 comments · Fixed by #67
Assignees

Comments

@blefaudeux
Copy link
Contributor

🚀 Feature

Make sure that all attributes (not just LR) are in sync in between the OSS.param_groups and the actual optimizer.

Motivation

Some frameworks make it possible to alter any attribute here, not just LR (momentum, beta for Adam, ..). We do not currently support this and silently fail

Pitch

Part of the not really well defined PyTorch optimizer features which are nice to have

Alternatives

  • At least add a warning when we're out of sync
  • Nuke the .param_groups access
  • Force a new OSS optimizer to be created everytime the user wants to change an attribute in param_groups

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant