-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making the C API more convenient to use #4181
Comments
@kaivalnp How did you access the C API If you want faiss to link to the right build from Lines 43 to 45 in aff6bfc
|
@mengdilin I built it locally, since it is not available from conda -- I opened this issue to ask for the C API to be published to conda so that users don't have to build it themselves
|
Gotcha, will back it into a feature request and follow up with the team on the work |
Thanks @mengdilin! Do let me know if I can help with some PRs (in case you agree with the suggestions).. |
@kaivalnp if you are happy to submit PRs to expose C-APIs to conda publication with validation steps, I am happy to review your PRs :D Right now the team is a bit overwhelmed with other asks so we may not get to this ask as quickly |
@mengdilin I'm not super familiar with the publish process (or the repo in general), but I took an attempt in #4186 :) |
libfaiss_c.so
) to Conda, so that users don't have to build it locally?libfaiss_c.so
is currently linked tolibfaiss.so
, but we don't have optimized versions of the library (AVX2, AVX512, SVE, etc). This could be overcome offline with something likepatchelf
(replacelibfaiss.so
dependency with optimized version), but can we start creating (and publishing) equivalent versions of the C API likelibfaiss_avx2.so
->libfaiss_c_avx2.so
, etcThe text was updated successfully, but these errors were encountered: