Some fixes for building on windows + cuda

[h-vetinari]

Upstreaming some work towards #1586 from conda-forge/faiss-split-feedstock#19; complements #1610

[facebook-github-bot]

@wickedfoo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[wickedfoo]

Thanks for the diff! I've imported it internally and take a look on Monday to make sure it passed our internal build and then will land it.

[h-vetinari]

Cool, happy to hear it!

Together with d2c04d0 and the commits here, I managed to get to the linker stage in conda-forge/faiss-split-feedstock#19, but there it fails with

Auto build dll exports
     Creating library D:/bld/faiss-split_1610238297983/work/_build/faiss/Release/faiss.lib and object D:/bld/faiss-split_1610238297983/work/_build/faiss/Release/faiss.exp
GpuIndexIVFFlat.obj : error LNK2019: unresolved external symbol "public: __cdecl faiss::gpu::IVFFlat::IVFFlat(class faiss::gpu::GpuResources *,struct faiss::gpu::FlatIndex *,enum faiss::MetricType,float,bool,struct faiss::ScalarQuantizer *,enum faiss::gpu::IndicesOptions,enum faiss::gpu::MemorySpace)" (??0IVFFlat@gpu@faiss@@QEAA@PEAVGpuResources@12@PEAUFlatIndex@12@W4MetricType@2@M_NPEAUScalarQuantizer@2@W4IndicesOptions@12@W4MemorySpace@12@@Z) referenced in function "public: __cdecl faiss::gpu::GpuIndexIVFFlat::GpuIndexIVFFlat(class faiss::gpu::GpuResourcesProvider *,struct faiss::IndexIVFFlat const *,struct faiss::gpu::GpuIndexIVFFlatConfig)" (??0GpuIndexIVFFlat@gpu@faiss@@QEAA@PEAVGpuResourcesProvider@12@PEBUIndexIVFFlat@2@UGpuIndexIVFFlatConfig@12@@Z) [D:\bld\faiss-split_1610238297983\work\_build\faiss\faiss.vcxproj]
GpuIndexIVFScalarQuantizer.obj : error LNK2001: unresolved external symbol "public: __cdecl faiss::gpu::IVFFlat::IVFFlat(class faiss::gpu::GpuResources *,struct faiss::gpu::FlatIndex *,enum faiss::MetricType,float,bool,struct faiss::ScalarQuantizer *,enum faiss::gpu::IndicesOptions,enum faiss::gpu::MemorySpace)" (??0IVFFlat@gpu@faiss@@QEAA@PEAVGpuResources@12@PEAUFlatIndex@12@W4MetricType@2@M_NPEAUScalarQuantizer@2@W4IndicesOptions@12@W4MemorySpace@12@@Z) [D:\bld\faiss-split_1610238297983\work\_build\faiss\faiss.vcxproj]
GpuIndexIVFPQ.obj : error LNK2019: unresolved external symbol "public: __cdecl faiss::gpu::IVFPQ::IVFPQ(class faiss::gpu::GpuResources *,enum faiss::MetricType,float,struct faiss::gpu::FlatIndex *,int,int,bool,bool,bool,float *,enum faiss::gpu::IndicesOptions,enum faiss::gpu::MemorySpace)" (??0IVFPQ@gpu@faiss@@QEAA@PEAVGpuResources@12@W4MetricType@2@MPEAUFlatIndex@12@HH_N33PEAMW4IndicesOptions@12@W4MemorySpace@12@@Z) referenced in function "public: void __cdecl faiss::gpu::GpuIndexIVFPQ::copyFrom(struct faiss::IndexIVFPQ const *)" (?copyFrom@GpuIndexIVFPQ@gpu@faiss@@QEAAXPEBUIndexIVFPQ@3@@Z) [D:\bld\faiss-split_1610238297983\work\_build\faiss\faiss.vcxproj]
D:\bld\faiss-split_1610238297983\work\_build\faiss\Release\faiss.dll : fatal error LNK1120: 2 unresolved externals [D:\bld\faiss-split_1610238297983\work\_build\faiss\faiss.vcxproj]

which I haven't been able to resolve.

[facebook-github-bot]

@wickedfoo merged this pull request in 3d3d539.