Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] output_subdir: null does not work for multirun #1773

Closed
nkueng opened this issue Aug 17, 2021 · 8 comments
Closed

[Bug] output_subdir: null does not work for multirun #1773

nkueng opened this issue Aug 17, 2021 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@nkueng
Copy link

nkueng commented Aug 17, 2021

🐛 Bug

Description

Disabling the ouput of a .yaml file via hydra.output_subdir: null works for the standard use-case but not in multirun. This still produces an undesired multirun.yaml.

Checklist

  • [x ] I checked on the latest version of Hydra
  • [x ] I created a minimal repro (See this for tips).

To reproduce

Following the intro tutorial should reproduce the issue with the following conf/config.yaml:

defaults:
  - db: mysql
  
hydra:
  run:
    dir: .
  output_subdir: null
  sweep:
    dir: .
    subdir: .

This yields the unwanted multirun.yaml in directory ..

Expected Behavior

No output at all.

System information

  • Hydra Version : 1.1
  • Python version : 3.8
  • Virtual environment type and version : virtualenv
  • Operating system : Linux Mint 20 Cinnamon

Additional context

On a side note, the description for output_subdir mentiones None instead of null.

@nkueng nkueng added the bug Something isn't working label Aug 17, 2021
@nkueng nkueng changed the title [Bug] output_subdir: null does not work for multirun [Bug] output_subdir: null does not work for multirun Aug 17, 2021
@Jasha10
Copy link
Collaborator

Jasha10 commented Aug 17, 2021

Hello @nkueng,
Thank you for the bug report!
We will look into it.

@Jasha10 Jasha10 self-assigned this Aug 17, 2021
@omry
Copy link
Collaborator

omry commented Aug 17, 2021

output_dir is controlling the creation of the .hydra directory. multirun.yaml is created unconditionally.

@Jasha10
Copy link
Collaborator

Jasha10 commented Aug 18, 2021

So I guess this is more of a feature request than a bug report...

@omry
Copy link
Collaborator

omry commented Aug 18, 2021

Yes, and it's intertwined with #910 and is most likely what the author is really after.

@Jasha10
Copy link
Collaborator

Jasha10 commented Aug 18, 2021

Good point. I think we should be able to close this issue in favor of #910. @nkueng, is that ok with you?

@nkueng
Copy link
Author

nkueng commented Aug 19, 2021

Thanks for the quick action! Indeed it goes along the lines of #910, but unlike stated there, there is currently no workaround to disable the multirun.yaml in 1.1. This is inconsistent in my eyes, as it is possible to disable the same output for a regualr run (as described here). Thus, I am wondering, why the same method does not apply to the mulitrun output.

@nkueng nkueng closed this as completed Aug 19, 2021
@omry
Copy link
Collaborator

omry commented Aug 19, 2021

You are correct that there is no workaround for multirun.yaml right now. Working directory management will get some attention in the next version.

@nkueng
Copy link
Author

nkueng commented Aug 20, 2021

Anyways, thanks for developing such a nice tool! Even if I don't want to use the auto-generated outputs, it's heaps cool! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants