{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":217433767,"defaultBranch":"main","name":"pytorch3d","ownerLogin":"facebookresearch","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2019-10-25T02:23:45.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/16943930?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1719487945.0","currentOid":""},"activityList":{"items":[{"before":"38afdcfc6826bb41bbc414404937fab58dc24e85","after":"05cbea115acbbcbea77999c03d55155b23479991","ref":"refs/heads/main","pushedAt":"2024-08-15T23:22:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Hipify Pytorch3D (#1851)\n\nSummary:\nX-link: https://github.com/pytorch/pytorch/pull/133343\n\nX-link: https://github.com/fairinternal/pytorch3d/pull/45\n\nPull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/1851\n\nEnables pytorch3d to build on AMD. An important part of enabling this was not compiling the Pulsar backend when the target is AMD. There are simply too many kernel incompatibilites to make it work (I tried haha). Fortunately, it doesnt seem like most modern applications of pytorch3d rely on Pulsar. We should be able to unlock most of pytorch3d's goodness on AMD without it.\n\nReviewed By: bottler, houseroad\n\nDifferential Revision: D61171993\n\nfbshipit-source-id: fd4aee378a3568b22676c5bf2b727c135ff710af","shortMessageHtmlLink":"Hipify Pytorch3D (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2463867981\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/pytorch3d/issues/1851\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/pytorch3d/pull/1851/hovercard\" href=\"https://github.com/facebookresearch/pytorch3d/pull/1851\">#1851</a>)"}},{"before":"1e0b1d9c727e8d1a11df5c25a0722c3f9e12711b","after":"38afdcfc6826bb41bbc414404937fab58dc24e85","ref":"refs/heads/main","pushedAt":"2024-08-09T09:12:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"upgrade pyre version in `fbcode/vision` - batch 2\n\nReviewed By: bottler\n\nDifferential Revision: D60992234\n\nfbshipit-source-id: 899db6ed590ef966ff651c11027819e59b8401a3","shortMessageHtmlLink":"upgrade pyre version in <code>fbcode/vision</code> - batch 2"}},{"before":"44702fdb4ba0f80e96bee724766c545d4d93509c","after":"1e0b1d9c727e8d1a11df5c25a0722c3f9e12711b","ref":"refs/heads/main","pushedAt":"2024-08-07T20:50:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove Python versions from Install.md\n\nSummary: To avoid the installation instructions for PyTorch3D becoming out-of-date, instead of specifying certain Python versions, update to just `Python`. Reader will understand it has to be a Python version compatible with GitHub.\n\nReviewed By: bottler\n\nDifferential Revision: D60919848\n\nfbshipit-source-id: 5e974970a0db3d3d32fae44e5dd30cbc1ce237a9","shortMessageHtmlLink":"Remove Python versions from Install.md"}},{"before":"7edaee71a9583f8f1eedf91187aa77a0797c38e0","after":"44702fdb4ba0f80e96bee724766c545d4d93509c","ref":"refs/heads/main","pushedAt":"2024-08-02T17:51:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add \"max\" point reduction for chamfer distance\n\nSummary:\n* Adds a \"max\" option for the point_reduction input to the\n  chamfer_distance function.\n* When combining the x and y directions, maxes the losses instead\n  of summing them when point_reduction=\"max\".\n* Moves batch reduction to happen after the directions are\n  combined.\n* Adds test_chamfer_point_reduction_max and\n  test_single_directional_chamfer_point_reduction_max tests.\n\nFixes  https://github.com/facebookresearch/pytorch3d/issues/1838\n\nReviewed By: bottler\n\nDifferential Revision: D60614661\n\nfbshipit-source-id: 7879816acfda03e945bada951b931d2c522756eb","shortMessageHtmlLink":"Add \"max\" point reduction for chamfer distance"}},{"before":"d0d0e020071c34ffa0953c00f9e85be0672b597e","after":"7edaee71a9583f8f1eedf91187aa77a0797c38e0","ref":"refs/heads/main","pushedAt":"2024-07-16T18:34:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"allow matrix_to_quaternion onnx export\n\nSummary: Attempt to allow torch.onnx.dynamo_export(matrix_to_quaternion) to work.\n\nDifferential Revision: D59812279\n\nfbshipit-source-id: 4497e5b543bec9d5c2bdccfb779d154750a075ad","shortMessageHtmlLink":"allow matrix_to_quaternion onnx export"}},{"before":"4df110b0a94786bc6a312e6f5214ae6990492d88","after":"d0d0e020071c34ffa0953c00f9e85be0672b597e","ref":"refs/heads/main","pushedAt":"2024-07-16T09:24:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix: setting FrameData.crop_bbox_xywh for backwards compatibility\n\nSummary: This diff is fixing a backwards compatibility issue in PyTorch3D's dataset API. The code ensures that the `crop_bbox_xywh` attribute is set when box_crop flag is on. This is an implementation detail that people should not really use, however some people depend on this behaviour.\n\nReviewed By: bottler\n\nDifferential Revision: D59777449\n\nfbshipit-source-id: b875e9eb909038b8629ccdade87661bb2c39d529","shortMessageHtmlLink":"Fix: setting FrameData.crop_bbox_xywh for backwards compatibility"}},{"before":"51fd114d8b8eed19226870ee7fd12dba1e25d550","after":"4df110b0a94786bc6a312e6f5214ae6990492d88","ref":"refs/heads/main","pushedAt":"2024-07-11T11:39:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove fvcore dependency\n\nSummary: This is not actually needed and is causing a conda-forge confusion to do with python_abi - which needs users to have `-c conda-forge` when they install pytorch3d.\n\nReviewed By: patricklabatut\n\nDifferential Revision: D59587930\n\nfbshipit-source-id: 961ae13a62e1b2b2ce6d8781db38bd97eca69e65","shortMessageHtmlLink":"remove fvcore dependency"}},{"before":"89653419d0973396f3eff1a381ba09a07fffc2ed","after":"51fd114d8b8eed19226870ee7fd12dba1e25d550","ref":"refs/heads/main","pushedAt":"2024-06-27T14:39:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Forward fix internal pyre failure from D58983461\n\nSummary:\nX-link: https://github.com/pytorch/pytorch/pull/129525\n\nSomehow, using underscore alias of some builtin types breaks pyre\n\nReviewed By: malfet, clee2000\n\nDifferential Revision: D59029768\n\nfbshipit-source-id: cfa2171b66475727b9545355e57a8297c1dc0bc6","shortMessageHtmlLink":"Forward fix internal pyre failure from D58983461"}},{"before":"7980854d44903cbe1bd5adb983be1e0ee6f1765e","after":"89653419d0973396f3eff1a381ba09a07fffc2ed","ref":"refs/heads/main","pushedAt":"2024-06-25T14:10:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"version 0.7.7\n\nSummary: New version\n\nReviewed By: MichaelRamamonjisoa\n\nDifferential Revision: D58668979\n\nfbshipit-source-id: 195eaf83e4da51a106ef72e38dbb98c51c51724c","shortMessageHtmlLink":"version 0.7.7"}},{"before":"00c36ec01cf8046f8c6bbc91300cc4feba367f27","after":"7980854d44903cbe1bd5adb983be1e0ee6f1765e","ref":"refs/heads/main","pushedAt":"2024-06-21T15:18:57.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"require pytorch 2.0+\n\nSummary: Problems with timeouts on old builds.\n\nReviewed By: MichaelRamamonjisoa\n\nDifferential Revision: D58819435\n\nfbshipit-source-id: e1976534a102ad3841f3b297c772e916aeea12cb","shortMessageHtmlLink":"require pytorch 2.0+"}},{"before":"b0462d80799543c6ebec06d156a583f42209e9ff","after":"00c36ec01cf8046f8c6bbc91300cc4feba367f27","ref":"refs/heads/main","pushedAt":"2024-06-20T21:11:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update deprecated PyTorch functions in fbcode/vision\n\nReviewed By: bottler\n\nDifferential Revision: D58762015\n\nfbshipit-source-id: a0d05fe63a88d33e3f7783b5a7b2a476dd3a7449","shortMessageHtmlLink":"Update deprecated PyTorch functions in fbcode/vision"}},{"before":"14323725826280451d178a08c6c3ca828741fde9","after":"0eac8299d470a277d5331aec850a41fb4f543ae6","ref":"refs/heads/export-D58685326","pushedAt":"2024-06-20T16:24:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bottler","name":"Jeremy Reizenstein","path":"/bottler","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/669761?s=80&v=4"},"commit":{"message":"MKL version fix in CI (#1820)\n\nSummary:\nFix for \"undefined symbol: iJIT_NotifyEvent\" build issue,\n\nPull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/1820\n\nDifferential Revision: D58685326","shortMessageHtmlLink":"MKL version fix in CI (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2358032624\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/pytorch3d/issues/1820\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/pytorch3d/pull/1820/hovercard\" href=\"https://github.com/facebookresearch/pytorch3d/pull/1820\">#1820</a>)"}},{"before":"7cb513deb7dc7cee83a11ea5c9d92f93db47488a","after":"14323725826280451d178a08c6c3ca828741fde9","ref":"refs/heads/export-D58685326","pushedAt":"2024-06-19T17:57:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"MKL version fix in CI (#1820)\n\nSummary:\nFix for \"undefined symbol: iJIT_NotifyEvent\" build issue,\n\n\nDifferential Revision: D58685326","shortMessageHtmlLink":"MKL version fix in CI (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2358032624\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/pytorch3d/issues/1820\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/pytorch3d/pull/1820/hovercard\" href=\"https://github.com/facebookresearch/pytorch3d/pull/1820\">#1820</a>)"}},{"before":"cab98953b8aa2f361457b5a20ff5cc90dc46a4cc","after":"7cb513deb7dc7cee83a11ea5c9d92f93db47488a","ref":"refs/heads/export-D58685326","pushedAt":"2024-06-19T17:32:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"MKL version fix in CI (#1820)\n\nSummary:\nFix for \"undefined symbol: iJIT_NotifyEvent\" build issue,\n\n\nDifferential Revision: D58685326","shortMessageHtmlLink":"MKL version fix in CI (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2358032624\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/pytorch3d/issues/1820\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/pytorch3d/pull/1820/hovercard\" href=\"https://github.com/facebookresearch/pytorch3d/pull/1820\">#1820</a>)"}},{"before":"0896189bfc0656565384c4734e622603b251a853","after":"cab98953b8aa2f361457b5a20ff5cc90dc46a4cc","ref":"refs/heads/export-D58685326","pushedAt":"2024-06-19T16:59:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"MKL version fix in CI (#1820)\n\nSummary:\nFix for \"undefined symbol: iJIT_NotifyEvent\" build issue,\n\n\nDifferential Revision: D58685326","shortMessageHtmlLink":"MKL version fix in CI (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2358032624\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/pytorch3d/issues/1820\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/pytorch3d/pull/1820/hovercard\" href=\"https://github.com/facebookresearch/pytorch3d/pull/1820\">#1820</a>)"}},{"before":"633f98374823ff88f4e8301bf0f2abb173cf8cc5","after":"0896189bfc0656565384c4734e622603b251a853","ref":"refs/heads/export-D58685326","pushedAt":"2024-06-19T13:14:05.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"MKL version fix in CI (#1820)\n\nSummary:\nFix for \"undefined symbol: iJIT_NotifyEvent\" build issue, see https://github.com/pytorch/pytorch/issues/123097\n\n\nDifferential Revision: D58685326","shortMessageHtmlLink":"MKL version fix in CI (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2358032624\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/pytorch3d/issues/1820\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/pytorch3d/pull/1820/hovercard\" href=\"https://github.com/facebookresearch/pytorch3d/pull/1820\">#1820</a>)"}},{"before":"6d82efd9fa58d08a0fa4d29ad6d869a8779e645f","after":"633f98374823ff88f4e8301bf0f2abb173cf8cc5","ref":"refs/heads/export-D58685326","pushedAt":"2024-06-19T12:47:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"MKL version fix in CI (#1820)\n\nSummary:\nFix for \"undefined symbol: iJIT_NotifyEvent\" build issue, see https://github.com/pytorch/pytorch/issues/123097\n\n\nDifferential Revision: D58685326","shortMessageHtmlLink":"MKL version fix in CI (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2358032624\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/pytorch3d/issues/1820\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/pytorch3d/pull/1820/hovercard\" href=\"https://github.com/facebookresearch/pytorch3d/pull/1820\">#1820</a>)"}},{"before":"14f3ec3f6a74645e5b0a209c297ef8b2ec330375","after":"6d82efd9fa58d08a0fa4d29ad6d869a8779e645f","ref":"refs/heads/export-D58685326","pushedAt":"2024-06-17T19:01:17.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"avoid CPU-only PyTorch in CI (#1820)\n\nSummary: Pull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/1820\n\nDifferential Revision: D58685326","shortMessageHtmlLink":"avoid CPU-only PyTorch in CI (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2358032624\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/pytorch3d/issues/1820\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/pytorch3d/pull/1820/hovercard\" href=\"https://github.com/facebookresearch/pytorch3d/pull/1820\">#1820</a>)"}},{"before":null,"after":"14f3ec3f6a74645e5b0a209c297ef8b2ec330375","ref":"refs/heads/export-D58685326","pushedAt":"2024-06-17T18:56:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"avoid CPU-only PyTorch in CI\n\nDifferential Revision: D58685326","shortMessageHtmlLink":"avoid CPU-only PyTorch in CI"}},{"before":"b66d17a32459810137b158524b06467cb7b2f2a9","after":"b0462d80799543c6ebec06d156a583f42209e9ff","ref":"refs/heads/main","pushedAt":"2024-06-17T14:50:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Allow indexing for classes inheriting Transform3d (#1801)\n\nSummary:\nCurrently, it is not possible to access a sub-transform using an indexer for all 3d transforms inheriting the `Transforms3d` class.\nFor instance:\n\n```python\nfrom pytorch3d import transforms\n\nN = 10\nr = transforms.random_rotations(N)\nT = transforms.Transform3d().rotate(R=r)\nR = transforms.Rotate(r)\n\nx = T[0]  # ok\nx = R[0]  # TypeError: __init__() got an unexpected keyword argument 'matrix'\n```\n\nThis is because all these classes (namely `Rotate`, `Translate`, `Scale`, `RotateAxisAngle`) inherit the `__getitem__()` method from `Transform3d` which has the [following code on line 201](https://github.com/facebookresearch/pytorch3d/blob/main/pytorch3d/transforms/transform3d.py#L201):\n\n```python\nreturn self.__class__(matrix=self.get_matrix()[index])\n```\n\nThe four classes inheriting `Transform3d` are not initialized through a matrix argument, hence they error.\nI propose to modify the `__getitem__()` method of the `Transform3d` class to fix this behavior. The least invasive way to do it I can think of consists of creating an empty instance of the current class, then setting the `_matrix` attribute manually. Thus, instead of\n```python\nreturn self.__class__(matrix=self.get_matrix()[index])\n```\nI propose to do:\n```python\ninstance = self.__class__.__new__(self.__class__)\ninstance._matrix = self.get_matrix()[index]\nreturn instance\n```\n\nAs far as I can tell, this modification occurs no modification whatsoever for the user, except for the ability to index all 3d transforms.\n\nPull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/1801\n\nReviewed By: MichaelRamamonjisoa\n\nDifferential Revision: D58410389\n\nPulled By: bottler\n\nfbshipit-source-id: f371e4c63d2ae4c927a7ad48c2de8862761078de","shortMessageHtmlLink":"Allow indexing for classes inheriting Transform3d (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2313239198\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/pytorch3d/issues/1801\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/pytorch3d/pull/1801/hovercard\" href=\"https://github.com/facebookresearch/pytorch3d/pull/1801\">#1801</a>)"}},{"before":"717493cb79f16e67a0d64653bbfd36558683f78b","after":"b66d17a32459810137b158524b06467cb7b2f2a9","ref":"refs/heads/main","pushedAt":"2024-06-17T14:13:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Undo c10=>std optional rename\n\nSummary: Undoes the pytorch3d changes in D57294278 because they break builds for for PyTorch<2.1 .\n\nReviewed By: MichaelRamamonjisoa\n\nDifferential Revision: D57379779\n\nfbshipit-source-id: 47a12511abcec4c3f4e2f62eff5ba99deb2fab4c","shortMessageHtmlLink":"Undo c10=&gt;std optional rename"}},{"before":"302da69461b372a3f35c11214c9c826ebd2b336e","after":"717493cb79f16e67a0d64653bbfd36558683f78b","ref":"refs/heads/main","pushedAt":"2024-06-17T13:09:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fixed last dimension size check so that it doesn't trivially pass. (#1815)\n\nSummary:\nCurrently, it checks that the `2`th dimension of `p2` is the same size as the `2`th dimension of `p2` instead of `p1`.\n\nPull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/1815\n\nReviewed By: MichaelRamamonjisoa\n\nDifferential Revision: D58586966\n\nPulled By: bottler\n\nfbshipit-source-id: d4f723fa264f90fe368c10825c1acdfdc4c406dc","shortMessageHtmlLink":"Fixed last dimension size check so that it doesn't trivially pass. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2352187299\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/pytorch3d/issues/1815\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/pytorch3d/pull/1815/hovercard\" href=\"https://github.com/facebookresearch/pytorch3d/pull/1815\">#…</a>"}},{"before":"4ae25bfce7eb42042a34585acc3df81cf4be7d85","after":"302da69461b372a3f35c11214c9c826ebd2b336e","ref":"refs/heads/main","pushedAt":"2024-06-17T13:03:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"builds for PyTorch 2.2.1 2.2.2 2.3.0 2.3.1\n\nSummary: Build for new pytorch versions\n\nReviewed By: MichaelRamamonjisoa\n\nDifferential Revision: D58668956\n\nfbshipit-source-id: 7fdfb377b370448d6147daded6a21b8db87586fb","shortMessageHtmlLink":"builds for PyTorch 2.2.1 2.2.2 2.3.0 2.3.1"}},{"before":"bd52f4a408b29dc6b4357b70c93fd7a9749ca820","after":"4ae25bfce7eb42042a34585acc3df81cf4be7d85","ref":"refs/heads/main","pushedAt":"2024-05-30T17:11:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Moving ray bundle to float dtype\n\nSummary: We can now move ray bundle to float dtype (e.g. from fp16 like types).\n\nReviewed By: bottler\n\nDifferential Revision: D57493109\n\nfbshipit-source-id: 4e18a427e968b646fe5feafbff653811cd007981","shortMessageHtmlLink":"Moving ray bundle to float dtype"}},{"before":"17117106e4dd8269c02271462539c9c4a5d0d5ec","after":"bd52f4a408b29dc6b4357b70c93fd7a9749ca820","ref":"refs/heads/main","pushedAt":"2024-05-13T23:45:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"c10::optional -> std::optional in tensorboard/adhoc/Adhoc.h +9\n\nSummary: `c10::optional` was switched to be `std::optional` after PyTorch moved to C++17. Let's eliminate `c10::optional`, if we can.\n\nReviewed By: albanD\n\nDifferential Revision: D57294278\n\nfbshipit-source-id: f6f26133c43f8d92a4588f59df7d689e7909a0cd","shortMessageHtmlLink":"c10::optional -&gt; std::optional in tensorboard/adhoc/Adhoc.h +9"}},{"before":"aec76bb4c859087f209351cabc23d2f25521321f","after":"17117106e4dd8269c02271462539c9c4a5d0d5ec","ref":"refs/heads/main","pushedAt":"2024-05-10T08:22:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"upgrade pyre version in `fbcode/vision` - batch 2\n\nDifferential Revision: D57183103\n\nfbshipit-source-id: 7e2f42ddc6a1fa02abc27a451987d67a00264cbb","shortMessageHtmlLink":"upgrade pyre version in <code>fbcode/vision</code> - batch 2"}},{"before":"47d5dc88247035b35ca3cfce159565f92d8fbb75","after":"aec76bb4c859087f209351cabc23d2f25521321f","ref":"refs/heads/main","pushedAt":"2024-05-02T21:03:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused-but-set variables in vision/fair/pytorch3d/pytorch3d/csrc/pulsar/include/renderer.render.device.h +1\n\nSummary:\nThis diff removes a variable that was set, but which was not used.\n\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused but set variables often indicate a programming mistake, but can also just be unnecessary cruft that harms readability and performance.\n\nRemoving this variable will not change how your code works, but the unused variable may indicate your code isn't working the way you thought it was. I've gone through each of these by hand, but mistakes may have slipped through. If you feel the diff needs changes before landing, **please commandeer** and make appropriate changes: there are hundreds of these and responding to them individually is challenging.\n\nFor questions/comments, contact r-barnes.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: bottler\n\nDifferential Revision: D56886956\n\nfbshipit-source-id: 0c515ed98b812b1c106a59e19ec90751ce32e8c0","shortMessageHtmlLink":"Remove unused-but-set variables in vision/fair/pytorch3d/pytorch3d/cs…"}},{"before":"fe0b1bae49e7144021a9eb63169e855f51dd4dd3","after":"47d5dc88247035b35ca3cfce159565f92d8fbb75","ref":"refs/heads/main","pushedAt":"2024-04-14T18:38:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Apply clang-format 18\n\nSummary: Previously this code conformed from clang-format 12.\n\nReviewed By: igorsugak\n\nDifferential Revision: D56065247\n\nfbshipit-source-id: f5a985dd8f8b84f2f9e1818b3719b43c5a1b05b3","shortMessageHtmlLink":"Apply clang-format 18"}},{"before":"ccf22911d4daa74af7fbf70b3373bc0fe46d6d7c","after":"fe0b1bae49e7144021a9eb63169e855f51dd4dd3","ref":"refs/heads/main","pushedAt":"2024-04-03T01:15:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"upgrade pyre version in `fbcode/vision` - batch 2\n\nDifferential Revision: D55650177\n\nfbshipit-source-id: d5faa4d805bb40fe3dea70b0601e7a1382b09f3a","shortMessageHtmlLink":"upgrade pyre version in <code>fbcode/vision</code> - batch 2"}},{"before":"128be02fc078a91031a3c88730737f2531cac142","after":"ccf22911d4daa74af7fbf70b3373bc0fe46d6d7c","ref":"refs/heads/main","pushedAt":"2024-04-02T14:54:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Optimize list_to_packed to avoid for loop (#1737)\n\nSummary:\nFor larger N and Mi value (e.g. N=154, Mi=238) I notice list_to_packed() has become a bottleneck for my application. By removing the for loop and running on GPU, i see a 10-20 x speedup.\n\nPull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/1737\n\nReviewed By: MichaelRamamonjisoa\n\nDifferential Revision: D54187993\n\nPulled By: bottler\n\nfbshipit-source-id: 16399a24cb63b48c30460c7d960abef603b115d0","shortMessageHtmlLink":"Optimize list_to_packed to avoid for loop (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2149964331\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/pytorch3d/issues/1737\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/pytorch3d/pull/1737/hovercard\" href=\"https://github.com/facebookresearch/pytorch3d/pull/1737\">#1737</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEm6ZG1gA","startCursor":null,"endCursor":null}},"title":"Activity · facebookresearch/pytorch3d"}