From b4e90dfbf11c95b58d53b5bf7bc33b007e5b6724 Mon Sep 17 00:00:00 2001 From: Yuta Inoue Date: Thu, 9 Mar 2023 13:06:32 -0800 Subject: [PATCH 1/2] Fix changelog information Summary: As in title description, fixing the todo in the changelog.md Differential Revision: D43954394 fbshipit-source-id: e83fd6df045c640b6edaa150a153b356af1e5d8c --- CHANGELOG.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0594683..70025a3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,6 @@ This file captures the main changes made to the pyvrs open source project since its creation. None of the changes made before pyvrs was open sourced are meant to be covered. -# TODO update this before open source -# Version 1.0 (December 16, 2021) +# Version 1.0.4 (Mar 7, 2023) - Initial private release. From 70416cc2acc6b6cd30697d14969a4366c987ebed Mon Sep 17 00:00:00 2001 From: Yuta Inoue Date: Thu, 9 Mar 2023 13:06:54 -0800 Subject: [PATCH 2/2] Disable M1 build in Github Actions Summary: It turns out that the M1 build is not working in Github Actions and will be supported in Q3 2023: https://github.com/actions/runner-images/issues/2187 Since this doesn't work right now, disable this build Differential Revision: D43954575 fbshipit-source-id: 9636707ff59cc1747f24d3ac8a4222757e45941a --- .github/workflows/deploy.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index e2e1753..dd37717 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -68,7 +68,9 @@ jobs: python3 -m cibuildwheel --output-dir dist env: CIBW_ARCHS_LINUX: x86_64 - CIBW_ARCHS_MACOS: "x86_64 arm64" + # apple M1 image is not supported yet in Github Action: https://github.com/actions/runner-images/issues/2187 + # We need to manually build this locally until this will be supported. + CIBW_ARCHS_MACOS: x86_64 # "x86_64 arm64" CIBW_BUILD: "cp37-*64 cp38-*64 cp39-*64 cp310-*64 cp311-*64" CIBW_BEFORE_BUILD_LINUX: bash scripts/install-manylinux-deps.sh CIBW_BEFORE_BUILD_MACOS: bash scripts/install-macos-deps.sh