From 0dd19dfb90577c7edd546487852df9f9f6cb6f20 Mon Sep 17 00:00:00 2001
From: danthe3rd <43445237+danthe3rd@users.noreply.github.com>
Date: Wed, 11 Sep 2024 13:38:40 +0000
Subject: [PATCH] [ci] Update download-artifact

ghstack-source-id: 3204616cecd297f658bda0cf31e82ba0edf491c6
Pull Request resolved: https://github.com/fairinternal/xformers/pull/1215

__original_commit__ = fairinternal/xformers@adc8664f42cec70eb66d99b6d7b3ba5f2d59782c
---
 .github/workflows/conda.yml             | 4 ++--
 .github/workflows/wheels_build.yml      | 2 +-
 .github/workflows/wheels_upload_pip.yml | 2 +-
 .github/workflows/wheels_upload_s3.yml  | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/conda.yml b/.github/workflows/conda.yml
index 671b561f16..62a7063143 100644
--- a/.github/workflows/conda.yml
+++ b/.github/workflows/conda.yml
@@ -145,9 +145,9 @@ jobs:
               echo "Attempt $i"
               anaconda upload --user xformers --label ${XFORMERS_CONDA_TAG} packages/* && break
           done
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         if: success() || failure()
         with:
-          name: linux-py${{ matrix.python }}-torch${{ matrix.config.torch_version }}
+          name: linux-py${{ matrix.python }}-torch${{ matrix.config.torch_version }}-cu${{ matrix.config.cuda_short_version }}
           path: packages
 # Note: it might be helpful to have additional steps that test if the built wheels actually work
diff --git a/.github/workflows/wheels_build.yml b/.github/workflows/wheels_build.yml
index 38108bdfae..cb59407059 100644
--- a/.github/workflows/wheels_build.yml
+++ b/.github/workflows/wheels_build.yml
@@ -122,7 +122,7 @@ jobs:
           PLAT_ARG: ${{ contains(inputs.os, 'ubuntu') && '--plat-name manylinux_2_28_x86_64' || '' }}
 
       - run: du -h dist/*
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: ${{ inputs.os }}-py${{ inputs.python }}-torch${{ inputs.torch_version }}+${{ contains(inputs.toolkit_type, 'cuda') && 'cu' || 'rocm' }}${{ inputs.toolkit_short_version }}_${{ inputs.artifact_tag }}
           path: dist/*.whl
diff --git a/.github/workflows/wheels_upload_pip.yml b/.github/workflows/wheels_upload_pip.yml
index dc2d917555..a4a4c2a015 100644
--- a/.github/workflows/wheels_upload_pip.yml
+++ b/.github/workflows/wheels_upload_pip.yml
@@ -56,7 +56,7 @@ jobs:
           echo "${{ inputs.pypirc }}" > ~/.pypirc
           cat ~/.pypirc
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           path: dist
 
diff --git a/.github/workflows/wheels_upload_s3.yml b/.github/workflows/wheels_upload_s3.yml
index 179c388d0d..7a7462d4b5 100644
--- a/.github/workflows/wheels_upload_s3.yml
+++ b/.github/workflows/wheels_upload_s3.yml
@@ -54,7 +54,7 @@ jobs:
           sudo rm -rf /usr/local/lib/android || true
           sudo rm -rf /usr/share/dotnet || true
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           path: dist
       # Filter builds (eg vN+cu118 for instance)