Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperFences and CodeHilite problem #893

Closed
tjapro opened this issue Apr 15, 2020 · 2 comments
Closed

SuperFences and CodeHilite problem #893

tjapro opened this issue Apr 15, 2020 · 2 comments
Labels
T: support Support request.

Comments

@tjapro
Copy link

tjapro commented Apr 15, 2020

Hello!

I have a Mkdocs project with CodeHilite and SuperFences.
I notice that CodeHilite doesn't show anymore the line numbers (it is true globally).
So I remove one by one the extensions and plugins and discover that SuperFences somehow disables the line numbers.
There is some problem between the extensions?

@gir-bot gir-bot added the S: triage Issue needs triage. label Apr 15, 2020
@facelessuser
Copy link
Owner

A long time ago, SuperFences used CodeHilite to do highlighting, much like markdown.extensions.fenced_code does. But we wanted to implement things that CodeHilite could not, so we created Highlight.

We didn't want to break people, so for a while, if CodeHilite was being used, and Highlight was not explicitly configured, we would copy CodeHilite options over to Highlight to configure it. It was always meant to be temporary. But even during this temporary time in which we mirrored the options, we were not using CodeHilite anymore, but we were using Highlight. Well, the temporary time is over, we no longer look at CodeHilite options. You need to configure Highlight instead.

@gir-bot remove S: triage
@gir-bot add T: support

@gir-bot gir-bot added T: support Support request. and removed S: triage Issue needs triage. labels Apr 15, 2020
@tjapro
Copy link
Author

tjapro commented Apr 15, 2020

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: support Support request.
Projects
None yet
Development

No branches or pull requests

3 participants